Skip to content

Commit

Permalink
sys: rm SAN hack including 0 etcd host in all certs
Browse files Browse the repository at this point in the history
Issue resolved in >v1.16.3
kubernetes/kubernetes#72102 (comment)
  • Loading branch information
george-angel committed Feb 27, 2020
1 parent b4a1e30 commit 4943e8d
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions etcd.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ data "template_file" "etcd-cfssl-new-cert" {
org = ""
get_ip = var.get_ip_command[var.cloud_provider]
get_hostname = var.node_name_command[var.cloud_provider]
# workaround for https://github.com/kubernetes/kubernetes/issues/72102
# include first member's ip in SAN for all nodes
# this replicates kubeadm behaviour to include first node's ip, as kubeadm
# generates all certificates on the first node
extra_names = join(",", ["etcd.${var.dns_domain}", var.etcd_addresses[0]])
extra_names = join(",", ["etcd.${var.dns_domain}"])
}
}

Expand Down

0 comments on commit 4943e8d

Please sign in to comment.