chore(spec): Update BlockHeader and Tx to conform to specification #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reflect U5C spec Also renamed BlockRef.Index -> Slot
This was referenced Jan 28, 2024
Mercurial
changed the title
Mercurial
requested review from
scarmuega and
domMayhew
and removed request for
scarmuega
domMayhew
reviewed
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds / updates the following structure to conform to th U5C specs.
BlockHeader:
Before
After
Spec
Adding the block number / height also addresses the issue: #29
Tx:
In the case of
TxI'm proposing adding the fieldhash: bytesto the specificiation that is the hash the tx.As pointed out by this issue: #24