Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new version #431

Closed
nox opened this issue Oct 15, 2019 · 15 comments · Fixed by #433
Closed

Release a new version #431

nox opened this issue Oct 15, 2019 · 15 comments · Fixed by #433

Comments

@nox
Copy link
Contributor

nox commented Oct 15, 2019

I'm looking into bumping rand in Servo, could we make a new release with the recent rand bump here please?

@Dylan-DPC-zz
Copy link
Member

thanks @nox. We are working on a 0.8. release but in case this is a high priority, we could probably see if we can cut out a 0.7.x release with the upgrade. Will keep you updated :)

@nox
Copy link
Contributor Author

nox commented Oct 15, 2019

You can see the upgrade plan on servo/servo#24448, I'm not sure how reactive the other crates' maintainers will be so don't hurry too much. :)

@kinggoesgaming
Copy link
Member

Actually I was thinking that 0.8 is pretty good to go. The only thing missing is the TODO bits and docs which are not breaking changes so we can move them down to a point release

@nox
Copy link
Contributor Author

nox commented Oct 15, 2019 via email

@Dylan-DPC-zz
Copy link
Member

Yeah 0.8 is good but will need a review because we want to try and avoid another small major release in case we forgot anything.

@nox
Copy link
Contributor Author

nox commented Oct 16, 2019

Tell me if I can help in any way.

@Dylan-DPC-zz
Copy link
Member

We are always welcome to people reviewing the code, and suggesting/implementing changes or implementing anything from one of the issues :)

@nox
Copy link
Contributor Author

nox commented Oct 16, 2019

Sure, but review what, in that case? The individual PRs were all reviewed before landing, and 0.8 is otherwise ready, so LGTM?

@Dylan-DPC-zz
Copy link
Member

oops well yeah I mean review the existing Prs that were merged. Even though we reviewed them, another pair of eyes (or 2 pairs 👓 ) would be really helpful in case we missed anything. (Optional of course)

@nox
Copy link
Contributor Author

nox commented Oct 16, 2019

I skimmed quickly through all the landed PRs since 0.7.4 and nothing jumped to my eyes.

@Dylan-DPC-zz
Copy link
Member

@nox thanks :)

@KodrAus
Copy link
Member

KodrAus commented Oct 17, 2019

We just finished some fairly heavy refactoring in #427 so shouldn't need to break anything for a while. I'm happy to push it out @Dylan-DPC @kinggoesgaming if you're both happy!

I see we've got #432 open but it's a bit open-ended so I think it can wait.

@bors bors bot closed this as completed in aa6d78f Oct 17, 2019
@bors bors bot closed this as completed in #433 Oct 17, 2019
@KodrAus
Copy link
Member

KodrAus commented Oct 18, 2019

Done! We've just published 0.8.0.

@Dylan-DPC-zz
Copy link
Member

Dylan-DPC-zz commented Oct 18, 2019

@nox here you go https://crates.io/crates/uuid/0.8.0

@nox
Copy link
Contributor Author

nox commented Oct 18, 2019

Yep thanks to you two! I'm on it already. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants