Remove rand dependency for v3 and v5
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boddlnagg
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
|
Thanks. it is fine since we are not using the rand crate in v3 and v5, so this must be some residue that got left behind. |
Dylan-DPC-zz
approved these changes
Feb 28, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Feb 28, 2019
371: Remove `rand` dependency for v3 and v5 r=Dylan-DPC a=Boddlnagg I don't see why the v3 and v5 features depend on the `rand` crate, but maybe I'm missing something? If not, I would like to get rid of that dependency (which pulls in quite a number of crates transitively). `cargo test --features "v5 v3"` still passes locally. I don't think that removing a dependency is a breaking change. Co-authored-by: Patrick Reisert <kpreisert@gmail.com>
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see why the v3 and v5 features depend on the
randcrate, but maybe I'm missing something?If not, I would like to get rid of that dependency (which pulls in quite a number of crates transitively).
cargo test --features "v5 v3"still passes locally.I don't think that removing a dependency is a breaking change.