Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2018 edition #388

Merged
merged 17 commits into from
Mar 30, 2019
Merged

Feature/2018 edition #388

merged 17 commits into from
Mar 30, 2019

Conversation

kinggoesgaming
Copy link
Member

I'm submitting a(n) refactor

Description

  • Make MSRV to 1.31.0
  • Merges all the changes for 1.31.0 in the crate

Motivation

2018 edition has been for a while and its time we make uuid before 1.0

Tests

All current tests pass. No new tests added

Related Issue(s)

closes #364

Dylan-DPC and others added 17 commits August 25, 2018 19:44
prefix `crate::` to local imports
elide lifetime in impl
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming added Type:Refactor breaking This causes a breaking change and will be merged to breaking branch. labels Mar 30, 2019
@kinggoesgaming kinggoesgaming added this to the 0.8.0 milestone Mar 30, 2019
@kinggoesgaming kinggoesgaming self-assigned this Mar 30, 2019
@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Mar 30, 2019
388: Feature/2018 edition r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** refactor

# Description
* Make MSRV to 1.31.0
* Merges all the changes for 1.31.0 in the crate

# Motivation
`2018` edition has been for a while and its time we make `uuid` before `1.0`

# Tests
All current tests pass. No new tests added

# Related Issue(s)
closes #364 

Co-authored-by: dylan_DPC <dylan.dpc@gmail.com>
Co-authored-by: Dylan DPC <dylan.dpc@gmail.com>
Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 30, 2019

@bors bors bot merged commit 5d844bb into master Mar 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/2018-edition branch March 30, 2019 22:48
bors bot added a commit that referenced this pull request Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus

Closes #431 

[Changeset since the last release](0.7.4...master)

Includes:

- #427 
- #419 
- #424 
- #418 
- #413 
- #407 
- #404 
- #400 
- #399 
- #398 
- #397 
- #396 
- #394 
- #393 
- #390
- #389 
- #388 

I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild).

Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This causes a breaking change and will be merged to breaking branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate fully to 2018 edition
3 participants