Remove the set_version and set_variant methods #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
|
depends on #399 |
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
|
Ignore restyled for me |
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
KodrAus
reviewed
Apr 22, 2019
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 23, 2019
400: Remove the set_version and set_variant methods r=KodrAus a=kinggoesgaming **I'm submitting a(n)** removal # Description Removes `Uuid::set_variant` and `Uuid::set_version` # Motivation These methods were private and already `uuid::builder::Builder` was being recommended. # Tests Current tests should pass. # Related Issue(s) N/A Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus Closes #431 [Changeset since the last release](0.7.4...master) Includes: - #427 - #419 - #424 - #418 - #413 - #407 - #404 - #400 - #399 - #398 - #397 - #396 - #394 - #393 - #390 - #389 - #388 I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild). Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) removal
Description
Removes
Uuid::set_variantandUuid::set_versionMotivation
These methods were private and already
uuid::builder::Builderwas being recommended.Tests
Current tests should pass.
Related Issue(s)
N/A