docs: move react-native docs to separate section #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctavan
force-pushed
the
move-react-native-docs
branch
2 times, most recently
from
4b5c2a6
to
ba42dff
Compare
broofa
approved these changes
Feb 27, 2020
ctavan
force-pushed
the
move-react-native-docs
branch
from
ba42dff
to
3282056
Compare
For linkability, move react-native docs to separate section.
ctavan
force-pushed
the
move-react-native-docs
branch
from
3282056
to
c4e153c
Compare
|
The error message increased bundlesize slightly. I tried to reduce the error message as much as possible but still had to increase the bundlesize limits a tiny little bit. Fine for you @broofa ? |
|
Alternatively we could also shorten the error message to just a link and explain the rest in the readme. I guess that would be even better. |
broofa
requested changes
Feb 27, 2020
Co-Authored-By: Robert Kieffer <robert@broofa.com>
Co-Authored-By: Robert Kieffer <robert@broofa.com>
|
@broofa applied your changes and removed the bundlewatch sizelimit change. |
broofa
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.