From 8d591a7acce618ab3a9290f50487e9c0de22c5ed Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski Date: Thu, 30 Nov 2023 17:59:48 +0100 Subject: [PATCH 1/2] Bump freebsd-vm action to v1.0.2 & use ubuntu --- .github/workflows/freebsd.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml index 5af3da320a7..b932f9aa8f5 100644 --- a/.github/workflows/freebsd.yml +++ b/.github/workflows/freebsd.yml @@ -25,7 +25,7 @@ jobs: fail-fast: false matrix: job: - - { os: macos-12 , features: unix } ## GHA MacOS-11.0 VM won't have VirtualBox; refs: , + - { os: ubuntu-22.04 , features: unix } env: SCCACHE_GHA_ENABLED: "true" RUSTC_WRAPPER: "sccache" @@ -35,9 +35,11 @@ jobs: - name: Run sccache-cache uses: mozilla-actions/sccache-action@v0.0.3 - name: Prepare, build and test - uses: vmactions/freebsd-vm@v0.3.1 + uses: vmactions/freebsd-vm@v1.0.2 with: usesh: true + sync: rsync + copyback: false # We need jq to run show-utils.sh and bash to use inline shell string replacement prepare: pkg install -y curl sudo jq bash run: | @@ -48,11 +50,11 @@ jobs: # TEST_USER=tester REPO_NAME=${GITHUB_WORKSPACE##*/} - WORKSPACE_PARENT="/Users/runner/work/${REPO_NAME}" + WORKSPACE_PARENT="/home/runner/work/${REPO_NAME}" WORKSPACE="${WORKSPACE_PARENT}/${REPO_NAME}" # pw adduser -n ${TEST_USER} -d /root/ -g wheel -c "Coreutils user to build" -w random - chown -R ${TEST_USER}:wheel /root/ "/Users/runner/work/${REPO_NAME}"/ + chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ whoami # # Further work needs to be done in a sudo as we are changing users @@ -114,7 +116,7 @@ jobs: fail-fast: false matrix: job: - - { os: macos-12 , features: unix } ## GHA MacOS-11.0 VM won't have VirtualBox; refs: , + - { os: ubuntu-22.04 , features: unix } env: mem: 4096 SCCACHE_GHA_ENABLED: "true" @@ -125,10 +127,11 @@ jobs: - name: Run sccache-cache uses: mozilla-actions/sccache-action@v0.0.3 - name: Prepare, build and test - uses: vmactions/freebsd-vm@v0.3.1 + uses: vmactions/freebsd-vm@v1.0.2 with: usesh: true - # sync: sshfs + sync: rsync + copyback: false prepare: pkg install -y curl gmake sudo run: | ## Prepare, build, and test @@ -141,12 +144,12 @@ jobs: # TEST_USER=tester REPO_NAME=${GITHUB_WORKSPACE##*/} - WORKSPACE_PARENT="/Users/runner/work/${REPO_NAME}" + WORKSPACE_PARENT="/home/runner/work/${REPO_NAME}" WORKSPACE="${WORKSPACE_PARENT}/${REPO_NAME}" # pw adduser -n ${TEST_USER} -d /root/ -g wheel -c "Coreutils user to build" -w random # chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ - chown -R ${TEST_USER}:wheel /root/ "/Users/runner/work/${REPO_NAME}"/ + chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ whoami # # Further work needs to be done in a sudo as we are changing users From c6e7fdcabe46e9bcd903567900c11d7e230f9c1f Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski Date: Thu, 30 Nov 2023 18:45:06 +0100 Subject: [PATCH 2/2] skip test_cp_arg_update_interactive on FreeBSD --- tests/by-util/test_cp.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/by-util/test_cp.rs b/tests/by-util/test_cp.rs index 14b68da3718..36bca68b0d0 100644 --- a/tests/by-util/test_cp.rs +++ b/tests/by-util/test_cp.rs @@ -257,6 +257,8 @@ fn test_cp_target_directory_is_file() { } #[test] +// FixMe: for FreeBSD, flaky test; track repair progress at GH:uutils/coreutils/issue/4725 +#[cfg(not(target_os = "freebsd"))] fn test_cp_arg_update_interactive() { new_ucmd!() .arg(TEST_HELLO_WORLD_SOURCE)