-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lifting large unpacked constants is very slow #44
Comments
I guess this is not really a bug, so much as a consequence that DEVOID's cache doesn't understand unpacked constants, and so when it sees Consequentially, lift, lift, lift, unpack, unpack, unpack is much faster for large constants than lift, unpack, lift, unpack, lift, unpack, since caching is much better in the first case. |
So, e.g.:
When DEVOID gets to lifting I'm not sure what a good way to improve caching for this is, but here are some bad ways:
To use the unpacked cache regardless of how we construct it, when we go to lift something that references
We can substitute
And then we can lift the cached versions of those instead. Regardless, I think this an inconvenience but not too bad, so what I am going to do is add a bit to the README that notes we should unpack after lifting fully, and then plan to address this in the code after. The |
There should be some optimization for this
The text was updated successfully, but these errors were encountered: