From a6f37e51631aae2bc993101102e5a955efe78605 Mon Sep 17 00:00:00 2001 From: Victoriya Fedotova Date: Tue, 22 Oct 2024 04:09:29 -0700 Subject: [PATCH 1/2] Remove deselection of sparse sigmiod kernels tests --- onedal/svm/tests/test_csr_svm.py | 6 ++---- onedal/svm/tests/test_nusvr.py | 2 -- onedal/svm/tests/test_svr.py | 2 -- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/onedal/svm/tests/test_csr_svm.py b/onedal/svm/tests/test_csr_svm.py index e4a05a030e..d774b2c135 100644 --- a/onedal/svm/tests/test_csr_svm.py +++ b/onedal/svm/tests/test_csr_svm.py @@ -142,8 +142,8 @@ def _test_iris(queue, kernel): @pytest.mark.parametrize("queue", get_queues()) @pytest.mark.parametrize("kernel", ["linear", "rbf", "poly", "sigmoid"]) def test_iris(queue, kernel): - if kernel == "rbf": - pytest.skip("RBF CSR SVM test failing in 2025.0.") + # if kernel == "rbf": + # pytest.skip("RBF CSR SVM test failing in 2025.0.") _test_iris(queue, kernel) @@ -162,8 +162,6 @@ def _test_diabetes(queue, kernel): @pytest.mark.parametrize("queue", get_queues()) @pytest.mark.parametrize("kernel", ["linear", "rbf", "poly", "sigmoid"]) def test_diabetes(queue, kernel): - if kernel == "sigmoid": - pytest.skip("Sparse sigmoid kernel function is buggy.") _test_diabetes(queue, kernel) diff --git a/onedal/svm/tests/test_nusvr.py b/onedal/svm/tests/test_nusvr.py index 1bec991961..aafd5759c4 100644 --- a/onedal/svm/tests/test_nusvr.py +++ b/onedal/svm/tests/test_nusvr.py @@ -109,8 +109,6 @@ def _test_diabetes_compare_with_sklearn(queue, kernel): @pytest.mark.parametrize("queue", get_queues()) @pytest.mark.parametrize("kernel", ["linear", "rbf", "poly", "sigmoid"]) def test_diabetes_compare_with_sklearn(queue, kernel): - if kernel == "sigmoid": - pytest.skip("Sparse sigmoid kernel function is buggy.") _test_diabetes_compare_with_sklearn(queue, kernel) diff --git a/onedal/svm/tests/test_svr.py b/onedal/svm/tests/test_svr.py index a9000ff5f7..3e33f0190f 100644 --- a/onedal/svm/tests/test_svr.py +++ b/onedal/svm/tests/test_svr.py @@ -124,8 +124,6 @@ def _test_diabetes_compare_with_sklearn(queue, kernel): @pytest.mark.parametrize("queue", get_queues()) @pytest.mark.parametrize("kernel", ["linear", "rbf", "poly", "sigmoid"]) def test_diabetes_compare_with_sklearn(queue, kernel): - if kernel == "sigmoid": - pytest.skip("Sparse sigmoid kernel function is buggy.") _test_diabetes_compare_with_sklearn(queue, kernel) From b172cf7334f45cd0330d9f11f85f0d451795867b Mon Sep 17 00:00:00 2001 From: Victoriya Fedotova Date: Tue, 22 Oct 2024 04:11:56 -0700 Subject: [PATCH 2/2] Fix incorrect commenting out --- onedal/svm/tests/test_csr_svm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/onedal/svm/tests/test_csr_svm.py b/onedal/svm/tests/test_csr_svm.py index d774b2c135..5dfd3c037e 100644 --- a/onedal/svm/tests/test_csr_svm.py +++ b/onedal/svm/tests/test_csr_svm.py @@ -142,8 +142,8 @@ def _test_iris(queue, kernel): @pytest.mark.parametrize("queue", get_queues()) @pytest.mark.parametrize("kernel", ["linear", "rbf", "poly", "sigmoid"]) def test_iris(queue, kernel): - # if kernel == "rbf": - # pytest.skip("RBF CSR SVM test failing in 2025.0.") + if kernel == "rbf": + pytest.skip("RBF CSR SVM test failing in 2025.0.") _test_iris(queue, kernel)