Fix font icon style assignment (bsc#1231378) (#9329)

* Revert "Fixed missing pagination buttons icon" This reverts commit 92190d5. * Fix font icon style assignment (bsc#1231378)
uyuni-project · Oct 23, 2024 · d33a18e · d33a18e
1 parent 80b6bb3
commit d33a18e
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 6 deletions.
diff --git a/java/code/src/com/redhat/rhn/frontend/taglibs/list/ListTagUtil.java b/java/code/src/com/redhat/rhn/frontend/taglibs/list/ListTagUtil.java
@@ -550,7 +550,9 @@ public static void renderPaginationLinks(PageContext pageContext,
         for (String linkNameIn : linkNames) {
             String[] linkData = links.get(linkNameIn);
             ListTagUtil.write(pageContext, "<button ");
-            ListTagUtil.write(pageContext, "class=\"btn btn-default btn-xs");
+            ListTagUtil.write(pageContext, "class=\"btn btn-default btn-xs ");
+            ListTagUtil.write(pageContext, linkData[0]);
+
             // if the link is disabled...
             if (linkData[1] == null) {
                 ListTagUtil.write(pageContext, " disabled");
@@ -563,11 +565,7 @@ public static void renderPaginationLinks(PageContext pageContext,
             }
             ListTagUtil.write(pageContext, "\" title=\"");
             ListTagUtil.write(pageContext, linkData[3]);
-            ListTagUtil.write(pageContext, "\">");
-            ListTagUtil.write(pageContext, "<i class=\"");
-            ListTagUtil.write(pageContext, linkData[0]);
-            ListTagUtil.write(pageContext, "\"></i>");
-            ListTagUtil.write(pageContext, "</button>");
+            ListTagUtil.write(pageContext, "\"></button>");
         }
         ListTagUtil.write(pageContext, "</div>");
     }

diff --git a/java/spacewalk-java.changes.eth.fa2 b/java/spacewalk-java.changes.eth.fa2
@@ -0,0 +1 @@
+- Ensure icon fonts are loaded correctly on buttons (bsc#1231378)
diff --git a/web/html/src/branding/css/susemanager/components/icons.less b/web/html/src/branding/css/susemanager/components/icons.less
@@ -0,0 +1,8 @@
+.fa,
+[class^="fa-"] {
+  font-family: "FontAwesome";
+}
+
+[class*="spacewalk-icon-"] {
+  font-family: "spacewalk-icon";
+}
diff --git a/web/html/src/branding/css/susemanager/components/icons.scss b/web/html/src/branding/css/susemanager/components/icons.scss
@@ -0,0 +1,8 @@
+.fa,
+[class^="fa-"] {
+  font-family: "FontAwesome";
+}
+
+[class*="spacewalk-icon-"] {
+  font-family: "spacewalk-icon";
+}
diff --git a/web/html/src/branding/css/susemanager/index.less b/web/html/src/branding/css/susemanager/index.less
@@ -25,6 +25,7 @@
 @import "./components/date-time-picker.less";
 @import "./components/header.less";
 @import "./components/address.less";
+@import "./components/icons.less";
 
 // Responsive overrides
 @import "../base/responsive-rules.less";
diff --git a/web/html/src/branding/css/susemanager/index.scss b/web/html/src/branding/css/susemanager/index.scss
@@ -31,6 +31,7 @@
 @import "./components/legend.scss";
 @import "./components/help-block.scss";
 @import "./components/collapse.scss";
+@import "./components/icons.scss";
 
 @import "./bootstrap-fixes.scss";
 

diff --git a/web/spacewalk-web.changes.eth.fa2 b/web/spacewalk-web.changes.eth.fa2
@@ -0,0 +1 @@
+- Ensure icon fonts are loaded correctly on buttons (bsc#1231378)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Ensure icon fonts are loaded correctly on buttons (bsc#1231378)