fix idempotency of schema migration

[mcalmer]

What does this PR change?

fix idempotency of schema migration

Documentation

• No documentation needed: internal

• DONE

Test coverage

• No tests: fixes test

• DONE

[juliogonzalez]

gitarro no changelog needed !!!

[juliogonzalez]

LGTM, but please do not merge yet.

I see java_pgsql_tests is failing, but according to the log, gitarro runs this test with -f java/, which means it should only run if files inside java/ directory are changed, which is not the case for this PR.

@MalloZup any idea?

[juliogonzalez]

And besides, even if this PR does not change java/ I can't see why the test is failing :-(

[MalloZup]

we might open an issue with this PR referenced for further debugging

[mcalmer]

@juliogonzalez while it is goog to know why it is running even if it should not, I would suggest to run java tests always when the database schema changed.

[juliogonzalez]

@mcalmer, I agree, but I think we need to patch gitarro for that, to support multiple filters (instead of having more jobs and more gitarro instances running).

[MalloZup]

@juliogonzalez i would freeze the jenkin jobs number/or create an issue with this PR ref.

It might just be because we missed the qoutes "" , this could have an impact also on the parser. I dunno we might need to take look 😄

[juliogonzalez]

Job configured to be kept forever, and issue created at openSUSE/gitarro#132

Michael request about running java_pgsql_tests for SQL stuff generated the following feature request: openSUSE/gitarro#133

[juliogonzalez]

gitarro rerun java_pgsql_tests!!!

[juliogonzalez]

I am not 100% sure but I would think this kind of fake failure was happening to Franky some days ago, and he ran the test until it got green. Could be an infra problem.