Idempotency check fixes #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gitarro no changelog needed !!! |
juliogonzalez
force-pushed
the
idempotency-pr-fix
branch
29 times, most recently
from
6cdc1e3
to
74c9c2c
Compare
juliogonzalez
changed the title
juliogonzalez
force-pushed
the
idempotency-pr-fix
branch
from
74c9c2c
to
9d7e3e3
Compare
arguments with default value, remove trialing backslases from schema-dir and improve messaging
juliogonzalez
force-pushed
the
idempotency-pr-fix
branch
from
9d7e3e3
to
4ba5acb
Compare
MalloZup
approved these changes
Oct 4, 2018
|
Waiting for the tests, and then porting to the PRs for internal branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
GUI diff
No difference.
Documentation
No documentation needed: Internal fix
DONE
Test coverage
No tests: Fixing tests
DONE
Links
Fixes #
Tracks # add downstream PR, if any