-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC23] - B - Enable the downloading and synchronization of OVAL data #7509
[GSOC23] - B - Enable the downloading and synchronization of OVAL data #7509
Conversation
Suggested tests to cover this Pull Request
|
db77a92
to
5aa7563
Compare
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
6346edf
to
a777bed
Compare
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
a777bed
to
3fcedab
Compare
8f4ec9d
to
7fdcd2b
Compare
- If result is not empty, then server can be CVE audited normally otherwise a warning should be displayed indicating a lack of channels data and thus inaccuracies are expected.
- It doesn't bring much value + UI looks quite overloaded
Co-authored-by: Abid Mehmood <amehmood@suse.de>
…nels metadata not synced
- The 'scc' directory is not the best place to put this json file since it is not coming from SCC.
- The former does not accept a regex.
21cd978
to
81026c5
Compare
Signed-off-by: Pascal Arlt <parlt@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did one last round of going through the PR and checking if everything is working. Could not detect any issues. From my side this is ready to merge.
What does this PR change?
This is the implementation of the OVAL downloader component as stated in the linked RFC. Also adds support for SLE & Leap Micro OVAL-based CVE auditing.
TODO
log.error()
withlog.debug()
Useful Links
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: