Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-wording 'Monitoring' to 'Monitor this Host' on the systems properties (bsc#1212161) #9544

Merged

Conversation

CDellaGiusta
Copy link
Contributor

@CDellaGiusta CDellaGiusta commented Dec 5, 2024

What does this PR change?

The systems properties page had an item whose meaning was misleading, hence the request of rewording it

GUI diff

Before:
UI systems properties page / Add-on system types /
check-box named "Monitoring"

After:
same page
check-box named "Monitor this Host"

  • DONE

Documentation

Test coverage

  • No tests: already covered

  • [x ] DONE

Links

Issue(s):
Port(s): https://github.com/SUSE/spacewalk/pull/25907

  • [ x] DONE

Changelogs

  • [x ] No changelog needed

Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9544/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9544/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@CDellaGiusta CDellaGiusta self-assigned this Dec 5, 2024
@CDellaGiusta CDellaGiusta changed the title re-wording 'Monitoring' to 'Monitor this Host' on the systems propert… re-wording 'Monitoring' to 'Monitor this Host' on the systems properties (bsc#1212161) Dec 5, 2024
@CDellaGiusta CDellaGiusta force-pushed the uyuni-fix-properties-tab branch from e9fb47c to 2e2c416 Compare December 5, 2024 16:12
@CDellaGiusta CDellaGiusta merged commit d153273 into uyuni-project:master Dec 5, 2024
22 checks passed
@CDellaGiusta CDellaGiusta deleted the uyuni-fix-properties-tab branch December 5, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant