From ce325c07b4d62de9018b961c441f15b58ec942b1 Mon Sep 17 00:00:00 2001 From: Victor Gomes Date: Mon, 3 Jun 2024 13:45:51 +0200 Subject: [PATCH] Migrate to a new V8 interceptors Api (#180) The new callback should return v8::Intercepted::kYes/kNo to indicate whether the operation was intercepted. This replaces the old approach where the callback had to leave the return value unset or set it to an empty handle to indicate that the the request wasn't intercepted. See https://crrev.com/c/5465509 and https://crrev.com/c/5465513. # Conflicts: # src/node_contextify.cc # Conflicts: # src/node_contextify.cc # src/node_env_var.cc --- src/node_env_var.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_env_var.cc b/src/node_env_var.cc index d19d11dc714e08..e5cf6abda1c6ed 100644 --- a/src/node_env_var.cc +++ b/src/node_env_var.cc @@ -386,7 +386,6 @@ static Intercepted EnvSetter(Local property, } env->env_vars()->Set(env->isolate(), key, value_string); - return Intercepted::kYes; }