Vaadin 24 support + Move tabs and header to light dom #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paodb
force-pushed
the
tabs-to-light-dom
branch
from
30c61c8
to
cb9ef60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are meant to expose vaadin-tabs and header element to to the light DOM. This adjustment was requested -as part of a suppport request- to enhance accessibility & styling.
The Vaadin version was updated to 24 as there were some dependency conflicts with the component's previous version in Vaadin 24.
The changes are considered breaking so version of the component was updated to 3.0.0. This version is used in order to return to a better use of semver when defining the versions of this component (version 23.x should've been 2.x).