-
Notifications
You must be signed in to change notification settings - Fork 87
refactor: only show submenu indicator if there are child items #10472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-8 Bytes
(100%)
...s/context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-basic.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
...text-menu/test/visual/base/screenshots/context-menu/baseline/ltr-bottom-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3 Bytes
(100%)
...xt-menu/test/visual/base/screenshots/context-menu/baseline/ltr-bottom-start.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-26 Bytes
(100%)
.../context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-74 Bytes
(99%)
...text-menu/test/visual/base/screenshots/context-menu/baseline/ltr-end-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-66 Bytes
(99%)
...context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-end-top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-70 Bytes
(99%)
...ges/context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
.../context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-nested.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-58 Bytes
(99%)
...xt-menu/test/visual/base/screenshots/context-menu/baseline/ltr-start-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-81 Bytes
(99%)
...ntext-menu/test/visual/base/screenshots/context-menu/baseline/ltr-start-top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-73 Bytes
(99%)
...s/context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-start.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18 Bytes
(100%)
...context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-top-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-16 Bytes
(100%)
...ntext-menu/test/visual/base/screenshots/context-menu/baseline/ltr-top-start.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-93 Bytes
(99%)
...ges/context-menu/test/visual/base/screenshots/context-menu/baseline/ltr-top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...s/context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-basic.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12 Bytes
(100%)
...text-menu/test/visual/base/screenshots/context-menu/baseline/rtl-bottom-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12 Bytes
(100%)
...xt-menu/test/visual/base/screenshots/context-menu/baseline/rtl-bottom-start.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(100%)
.../context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-45 Bytes
(99%)
...text-menu/test/visual/base/screenshots/context-menu/baseline/rtl-end-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-70 Bytes
(99%)
...context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-end-top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-57 Bytes
(99%)
...ges/context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-100 Bytes
(99%)
.../context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-nested.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-65 Bytes
(99%)
...xt-menu/test/visual/base/screenshots/context-menu/baseline/rtl-start-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-59 Bytes
(99%)
...ntext-menu/test/visual/base/screenshots/context-menu/baseline/rtl-start-top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-62 Bytes
(99%)
...s/context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-start.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+19 Bytes
(100%)
...context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-top-end.png
Oops, something went wrong.
Binary file modified
BIN
+4 Bytes
(100%)
...ntext-menu/test/visual/base/screenshots/context-menu/baseline/rtl-top-start.png
Oops, something went wrong.
Binary file modified
BIN
-76 Bytes
(99%)
...ges/context-menu/test/visual/base/screenshots/context-menu/baseline/rtl-top.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/ltr-opened.png
Oops, something went wrong.
Binary file modified
BIN
+46 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/ltr-primary.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/ltr-tertiary.png
Oops, something went wrong.
Binary file modified
BIN
+31 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/rtl-opened.png
Oops, something went wrong.
Binary file modified
BIN
+16 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/rtl-primary.png
Oops, something went wrong.
Binary file modified
BIN
-16 Bytes
(100%)
packages/menu-bar/test/visual/base/screenshots/menu-bar/baseline/rtl-tertiary.png
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks kinda out of place.. should this logic also apply on the left side (check mark) if none of the menu entries are checkable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory yes, but that's a bit more complicated. There is an existing issue: #613
In short, the web component doesn't have a way to detect when the item is checkable, so we assume they are by default. This is also related to some missing a11y semantics - see #165 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was also the idea. But currently it’s not possible to know with CSS if an item is checkable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, I think we should make it easy to hide that empty space in a menu if the developer knows none of the items are checkable. I added a class name to each individual item in StarPass in such cases, but I think it would be easier if it could be applied on the whole menu. But there’s no API for that, is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no API in the web component indeed. Let's maybe discuss it in #613.