Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Transport: enable NO_DELAY for clients #822

Merged
merged 4 commits into from
Feb 14, 2023
Merged

TCP Transport: enable NO_DELAY for clients #822

merged 4 commits into from
Feb 14, 2023

Conversation

Menduist
Copy link
Contributor

@Menduist Menduist commented Dec 16, 2022

requires status-im/nim-chronos#340

I'm actually pro Naggle and think that delayed acks should get their sh*t together, but TCP_NO_DELAY is a lot easier to enable than TCP_QUICKACK :/

On linux platforms, having it both delayed acks & naggle can cause up to 40ms of unwanted delay

Gossipsub spread speed before / after: (don't mind the different scale on Y axis)
image

Maybe should be default?

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #822 (e792bed) into unstable (351bda2) will decrease coverage by 0.09%.
The diff coverage is 72.72%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #822      +/-   ##
============================================
- Coverage     83.73%   83.64%   -0.09%     
============================================
  Files            85       86       +1     
  Lines         15047    15169     +122     
============================================
+ Hits          12599    12688      +89     
- Misses         2448     2481      +33     
Impacted Files Coverage Δ
libp2p/utility.nim 75.86% <ø> (+51.72%) ⬆️
libp2p/transports/tcptransport.nim 79.64% <50.00%> (-0.36%) ⬇️
libp2p/wire.nim 61.53% <85.71%> (+1.79%) ⬆️
libp2p/protocols/pubsub/rpc/messages.nim 4.54% <0.00%> (-36.37%) ⬇️
libp2p/protocols/pubsub/gossipsub/scoring.nim 81.81% <0.00%> (-7.21%) ⬇️
libp2p/dial.nim 46.77% <0.00%> (-4.05%) ⬇️
libp2p/muxers/muxer.nim 79.54% <0.00%> (-3.39%) ⬇️
libp2p/protocols/pubsub/floodsub.nim 86.61% <0.00%> (-2.28%) ⬇️
libp2p/protocols/pubsub/rpc/message.nim 94.00% <0.00%> (-2.00%) ⬇️
libp2p/dialer.nim 91.26% <0.00%> (-1.20%) ⬇️
... and 35 more

@Menduist Menduist marked this pull request as ready for review January 24, 2023 16:11
@Menduist Menduist merged commit f7f1e89 into unstable Feb 14, 2023
@Menduist Menduist deleted the fixnodelay branch February 14, 2023 09:35
Menduist added a commit that referenced this pull request Feb 15, 2023
Menduist added a commit that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants