Merge pull request Smile-SA#2001 from rbayet/fix_1959_duplicate_optim…

…izer_date_handling Fixes Smile-SA#1959 Handle lack of dates when duplicating
vahonc · Nov 19, 2020 · 5aa4575 · 5aa4575
2 parents 06eb1d5 + 10bf974
commit 5aa4575
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Copier.php b/src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Copier.php
@@ -55,7 +55,9 @@ public function __construct(
      * Create optimizer duplicate
      *
      * @param OptimizerInterface $optimizer Optimizer model.
+     *
      * @return OptimizerInterface
+     * @SuppressWarnings(PHPMD.StaticAccess)
      */
     public function copy(OptimizerInterface $optimizer): OptimizerInterface
     {
@@ -67,8 +69,14 @@ public function copy(OptimizerInterface $optimizer): OptimizerInterface
         /** @var Optimizer $duplicate */
         $duplicate = $this->optimizerFactory->create();
         $duplicate->setData($optimizerData);
-        $duplicate->setFromDate(\DateTime::createFromFormat('Y-m-d', $optimizerData['from_date'])->format('m/d/Y'));
-        $duplicate->setToDate(\DateTime::createFromFormat('Y-m-d', $optimizerData['to_date'])->format('m/d/Y'));
+        if ($fromDate = \DateTime::createFromFormat('Y-m-d', $optimizerData['from_date'])) {
+            // Warning: user locale dependent.
+            $duplicate->setFromDate($fromDate->format('m/d/Y'));
+        }
+        if ($toDate = \DateTime::createFromFormat('Y-m-d', $optimizerData['to_date'])) {
+            // Warning: user locale dependent.
+            $duplicate->setToDate($toDate->format('m/d/Y'));
+        }
         $duplicate->setId(null);
 
         return $duplicate;