-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Splitted test/validators.js to multiple subfiles #1793
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2072 2072
Branches 472 472
=========================================
Hits 2072 2072 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Marcholio ! Thank you for your efforts ❤️
cc @ezkemboi @profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.
Yes, we will have merge conflicts, but, I like the idea of splitting tests. |
4e88e7e
to
12c8430
Compare
Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts. |
@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time. |
7f3e537
to
f2f18e5
Compare
@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 ) |
@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests. |
f2f18e5
to
26eb5c5
Compare
@tux-tn Rebased & solved the conflicts now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Marcholio !
@profnandaa Can we merge this PR?
@rubiin Do you think we can rebase this and merge it soon? |
Splitted the huge
test/validators.js
file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.
Fixes: #1791
Checklist