Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Type, Touch and Unlink commands #2756

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Go: Implement Type, Touch and Unlink commands #2756

wants to merge 7 commits into from

Conversation

EdricCua
Copy link

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@EdricCua EdricCua requested a review from a team as a code owner November 26, 2024 02:03
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Nov 26, 2024
@avifenesh
Copy link
Collaborator

@EdricCua Welcome! :)
Come say hi https://join.slack.com/t/valkey-oss-developer/shared_invite/zt-2nxs51chx-EB9hu9Qdch3GMfRcztTSkQ

janhavigupta007
janhavigupta007 requested changes Nov 26, 2024
View reviewed changes
go/api/generic_commands.go Outdated Show resolved Hide resolved
go/api/generic_commands.go Outdated Show resolved Hide resolved
go/api/generic_commands.go Show resolved Hide resolved
@EdricCua EdricCua closed this Nov 26, 2024
@EdricCua EdricCua deleted the Go-Implement-Type-Touch-Unlink branch November 26, 2024 12:51
@EdricCua EdricCua restored the Go-Implement-Type-Touch-Unlink branch November 27, 2024 06:16
@EdricCua EdricCua reopened this Nov 27, 2024
@EdricCua EdricCua force-pushed the Go-Implement-Type-Touch-Unlink branch 3 times, most recently from 02414aa to 9d2d3e5 Compare November 27, 2024 10:28
@EdricCua EdricCua force-pushed the Go-Implement-Type-Touch-Unlink branch from a59bb50 to 3bc9649 Compare November 28, 2024 06:48
yipin-chen
yipin-chen approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please address review comments.

@EdricCua
Go: Implement Type, Touch and Unlink command
dcc0e4d 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Fix documentation and unit test
c306309 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Bring back the TestDel_MultipleKeys and TestBlMove
e408c61 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Touch, Type, Unlink corrected doc comment
7ecc589 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Notice change adjustment based on valkey-io#2587 for Touch, Unlink, T…
f83e00c 
…ype.

Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Remove empty line
0a1b42a 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua
Corrected keys into key in comment
6fc4ab5 
Signed-off-by: EdricCua <ecuartero@google.com>
@EdricCua EdricCua force-pushed the Go-Implement-Type-Touch-Unlink branch from 2d15ac2 to 6fc4ab5 Compare December 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@janhavigupta007 janhavigupta007 janhavigupta007 requested changes

@yipin-chen yipin-chen yipin-chen approved these changes

@eifrah-aws eifrah-aws Awaiting requested review from eifrah-aws

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EdricCua @avifenesh @janhavigupta007 @Yury-Fridlyand @yipin-chen