Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add command SSCAN and SMOVE #2789

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Go: Add command SSCAN and SMOVE #2789

wants to merge 3 commits into from
+452 −0

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Dec 7, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): ISSUE TBD

SMove and SScan commands for the Golang wrapper

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review December 10, 2024 01:48
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner December 10, 2024 01:48
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/response_handlers.go Outdated Show resolved Hide resolved
go/api/set_commands.go Outdated Show resolved Hide resolved
go/api/set_commands.go Outdated Show resolved Hide resolved
go/api/set_commands.go Outdated Show resolved Hide resolved
go/api/set_commands.go Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Show resolved Hide resolved
go/integTest/shared_commands_test.go Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Dec 11, 2024
View reviewed changes
go/api/set_commands.go Outdated Show resolved Hide resolved
yipin-chen
yipin-chen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address all outstanding comments.

@janhavigupta007 janhavigupta007 added the go golang wrapper label Dec 12, 2024
@tjzhang-BQ tjzhang-BQ force-pushed the go/tjz-sscanmove branch 2 times, most recently from 0fa77fb to 4bef1a3 Compare December 13, 2024 23:50
TJ Zhang added 3 commits December 13, 2024 15:51
Go: Add command SSCAN and SMOVE
1094f55 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
update tests
6bb927c 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
address comments
9b52522 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjzhang-BQ @Yury-Fridlyand @yipin-chen @prateek-kumar-improving @janhavigupta007