Go: Add custom command to cluster client #2803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Open
jamesx-improving
approved these changes
Dec 11, 2024
yipin-chen
approved these changes
Dec 11, 2024
acarbonetto
reviewed
Dec 11, 2024
go/api/glide_client.go
Outdated
| // This function should only be used for single-response commands. Commands that don't return complete response and awaits | ||
| // (such as SUBSCRIBE), or that return potentially more than a single response (such as XREAD), or that change the client's | ||
| // behavior (such as entering pub/sub mode on RESP2 connections) shouldn't be called using this function. | ||
| // | ||
| // For example, to return a list of all pub/sub clients: | ||
| // | ||
| // client.CustomCommand([]string{"CLIENT", "LIST","TYPE", "PUBSUB"}) | ||
| // result, err := client.CustomCommand([]string{"CLIENT", "LIST", "TYPE", "PUBSUB"}) |
There was a problem hiding this comment.
example should include the result output, no?
There was a problem hiding this comment.
Should I update this for other clients as well?
tjzhang-BQ
approved these changes
Dec 12, 2024
janhavigupta007
requested changes
Dec 12, 2024
| // result.(string): "PONG" | ||
| // | ||
| // [Valkey GLIDE Wiki]: https://github.com/valkey-io/valkey-glide/wiki/General-Concepts#custom-command | ||
| func (client *GlideClusterClient) CustomCommand(args []string) (interface{}, error) { |
There was a problem hiding this comment.
Don't we want to handle the ClusterResponse support here? Ref: https://github.com/valkey-io/valkey-glide/blob/main/java/client/src/main/java/glide/api/commands/GenericClusterCommands.java#L37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.