-
Notifications
You must be signed in to change notification settings - Fork 70
feat: restyle Commands Page with new layout and search functionality #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
madolson
merged 1 commit into
valkey-io:main
from
phiro56:feat-ui-redesign-commands-page
May 9, 2025
Merged
feat: restyle Commands Page with new layout and search functionality #242
madolson
merged 1 commit into
valkey-io:main
from
phiro56:feat-ui-redesign-commands-page
May 9, 2025
+196
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
- Add left sidebar with command categories and alphabetical list - Implement responsive design with mobile-first approach - Add search functionality with real-time filtering - Style command groups with improved readability - Add no-results message for empty searches Signed-off-by: Daniel Phillips <phiro56@gmail.com>
This was referenced Apr 24, 2025
Merged
madolson
approved these changes
May 9, 2025
Member
madolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested everything on the latest changes.
madolson
added a commit
that referenced
this pull request
May 9, 2025
Loading
Loading status checks…
## Description
Restyle Topics Page layout and components
- Update left-aside layout with reversed flex direction
- Style topic cards with new background and hover states
- Add rounded corners to main content area
- Implement responsive layout adjustments for mobile/desktop
- Update typography and spacing for topic descriptions
### Dependencies
- This PR depends on
#[242](#242)
(feat-ui-redesign-commands-page)
- The changes in this PR should be reviewed and merged after the base PR
is merged
<img width="1728" alt="Screenshot 2025-04-24 at 1 20 16 PM"
src="https://github.com/user-attachments/assets/31875fcc-5331-41d7-85bf-5ac5523f096b"
/>
---------
Signed-off-by: Daniel Phillips <phiro56@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
added a commit
that referenced
this pull request
Jun 10, 2025
Loading
Loading status checks…
### Description Apply redesign ui to blog page and single post page ### Dependencies - This PR depends on #[242](#242) (feat-ui-redesign-commands-page) - The changes in this PR should be reviewed and merged after the base PR is merged <img width="1727" alt="Screenshot 2025-04-29 at 7 56 41 AM" src="https://github.com/user-attachments/assets/c4acdf97-4b66-445d-9de3-9e1cefff0b49" /> <img width="1728" alt="Screenshot 2025-04-29 at 7 56 21 AM" src="https://github.com/user-attachments/assets/fcd29069-32f6-4b9c-8cc8-da9a4063de1e" /> --------- Signed-off-by: Daniel Phillips <phiro56@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
zarkash-aws
pushed a commit
to zarkash-aws/valkey-io.github.io
that referenced
this pull request
Jun 12, 2025
…alkey-io#242) feat: restyle Commands Page with new layout and search functionality - Add left sidebar with command categories and alphabetical list - Implement responsive design with mobile-first approach - Add search functionality with real-time filtering - Style command groups with improved readability - Add no-results message for empty searches <img width="1727" alt="Screenshot 2025-04-18 at 7 43 52 PM" src="https://github.com/user-attachments/assets/e9bdbf91-bef4-4277-b944-d4fc1233a59d" /> <img width="1728" alt="Screenshot 2025-04-18 at 7 43 59 PM" src="https://github.com/user-attachments/assets/00df6c44-0a11-4361-aa6a-b77d81886c71" /> Signed-off-by: Daniel Phillips <phiro56@gmail.com> Signed-off-by: Shai Zarka <zarkash@amazon.com>
zarkash-aws
pushed a commit
to zarkash-aws/valkey-io.github.io
that referenced
this pull request
Jun 12, 2025
## Description
Restyle Topics Page layout and components
- Update left-aside layout with reversed flex direction
- Style topic cards with new background and hover states
- Add rounded corners to main content area
- Implement responsive layout adjustments for mobile/desktop
- Update typography and spacing for topic descriptions
### Dependencies
- This PR depends on
#[242](valkey-io#242)
(feat-ui-redesign-commands-page)
- The changes in this PR should be reviewed and merged after the base PR
is merged
<img width="1728" alt="Screenshot 2025-04-24 at 1 20 16 PM"
src="https://github.com/user-attachments/assets/31875fcc-5331-41d7-85bf-5ac5523f096b"
/>
---------
Signed-off-by: Daniel Phillips <phiro56@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Shai Zarka <zarkash@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: restyle Commands Page with new layout and search functionality