From e20c903a5b11c1d4c93e4bae60b043219e06775d Mon Sep 17 00:00:00 2001
From: Kathy Luo <kathyluo18@gmail.com>
Date: Fri, 27 Sep 2024 16:01:53 +0200
Subject: [PATCH 1/2] chore: update redux logger, analytics, remote config logs
 to reduce noise

---
 src/analytics/AppAnalytics.ts |  6 +++++-
 src/firebase/firebase.ts      |  2 --
 src/redux/sagas.ts            | 32 ++++++++++++++++++++++++++------
 3 files changed, 31 insertions(+), 9 deletions(-)

diff --git a/src/analytics/AppAnalytics.ts b/src/analytics/AppAnalytics.ts
index f529486d1b6..b8b8788c580 100644
--- a/src/analytics/AppAnalytics.ts
+++ b/src/analytics/AppAnalytics.ts
@@ -203,7 +203,11 @@ class AppAnalytics {
       ...eventProperties,
     }
 
-    Logger.info(TAG, `Tracking event ${eventName} with properties:`, props)
+    if (__DEV__) {
+      Logger.debug(TAG, `Tracking event ${eventName} with properties:`, props)
+    } else {
+      Logger.info(TAG, `Tracking event ${eventName}`)
+    }
 
     this.segmentClient.track(eventName, props).catch((err) => {
       Logger.error(TAG, `Failed to track event ${eventName}`, err)
diff --git a/src/firebase/firebase.ts b/src/firebase/firebase.ts
index 205a1920b0e..8b2190f201c 100644
--- a/src/firebase/firebase.ts
+++ b/src/firebase/firebase.ts
@@ -265,8 +265,6 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
   await remoteConfig().fetchAndActivate()
 
   const flags: FirebaseRemoteConfigTypes.ConfigValues = remoteConfig().getAll()
-  Logger.debug(TAG, `Updated remote config values:`, flags)
-
   // When adding a new remote config value there are 2 places that need updating:
   // the RemoteConfigValues interface as well as the REMOTE_CONFIG_VALUES_DEFAULTS map
   // REMOTE_CONFIG_VALUES_DEFAULTS is in remoteConfigValuesDefaults.ts
diff --git a/src/redux/sagas.ts b/src/redux/sagas.ts
index b3f9168dac5..ca3ece3728b 100644
--- a/src/redux/sagas.ts
+++ b/src/redux/sagas.ts
@@ -14,6 +14,7 @@ import {
   checkAndroidMobileServicesSaga,
 } from 'src/app/saga'
 import { dappsSaga } from 'src/dapps/saga'
+import { fetchDappsListCompleted } from 'src/dapps/slice'
 import { earnSaga } from 'src/earn/saga'
 import { fiatExchangesSaga } from 'src/fiatExchanges/saga'
 import { fiatConnectSaga } from 'src/fiatconnect/saga'
@@ -28,15 +29,23 @@ import { keylessBackupSaga } from 'src/keylessBackup/saga'
 import { localCurrencySaga } from 'src/localCurrency/saga'
 import { networkInfoSaga } from 'src/networkInfo/saga'
 import { nftsSaga } from 'src/nfts/saga'
+import { fetchNftsCompleted } from 'src/nfts/slice'
 import { pointsSaga } from 'src/points/saga'
 import { positionsSaga } from 'src/positions/saga'
+import { fetchPositionsSuccess, fetchShortcutsSuccess } from 'src/positions/slice'
 import { priceHistorySaga } from 'src/priceHistory/saga'
-import { setPhoneRecipientCache, updateAppRecipientCache } from 'src/recipients/reducer'
+import { fetchPriceHistorySuccess } from 'src/priceHistory/slice'
+import {
+  rewardsSendersFetched,
+  setPhoneRecipientCache,
+  updateAppRecipientCache,
+} from 'src/recipients/reducer'
 import { recipientsSaga } from 'src/recipients/saga'
 import { sendSaga } from 'src/send/saga'
 import { sentrySaga } from 'src/sentry/saga'
 import { swapSaga } from 'src/swap/saga'
 import { tokensSaga } from 'src/tokens/saga'
+import { setTokenBalances } from 'src/tokens/slice'
 import { Actions as TransactionActions } from 'src/transactions/actions'
 import { transactionSaga } from 'src/transactions/saga'
 import Logger from 'src/utils/Logger'
@@ -44,7 +53,9 @@ import { checkAccountExistenceSaga } from 'src/utils/accountChecker'
 import { walletConnectSaga } from 'src/walletConnect/saga'
 import { call, select, spawn, take, takeEvery } from 'typed-redux-saga'
 
-const loggerBlocklist = [
+// Actions that should not be logged along with their payload, particularly
+// those containing API responses, as they add unnecessary noise to the logs.
+const loggerPayloadBlocklist = [
   REHYDRATE,
   AppActions.PHONE_NUMBER_VERIFICATION_COMPLETED,
   AccountActions.SET_PHONE_NUMBER,
@@ -52,6 +63,14 @@ const loggerBlocklist = [
   setPhoneRecipientCache.toString(),
   updateAppRecipientCache.toString(),
   TransactionActions.UPDATE_TRANSACTIONS,
+  setTokenBalances.toString(),
+  fetchPriceHistorySuccess.toString(),
+  rewardsSendersFetched.toString(),
+  fetchDappsListCompleted.toString(),
+  fetchNftsCompleted.toString(),
+  fetchPositionsSuccess.toString(),
+  fetchShortcutsSuccess.toString(),
+  AppActions.UPDATE_REMOTE_CONFIG_VALUES,
 ]
 
 function* loggerSaga() {
@@ -63,11 +82,12 @@ function* loggerSaga() {
   yield* takeEvery('*', (action: UnknownAction) => {
     if (
       action?.type &&
-      (action.type.includes('IDENTITY/') || loggerBlocklist.includes(action.type))
+      (action.type.includes('IDENTITY/') || loggerPayloadBlocklist.includes(action.type))
     ) {
-      // Log only action type, but not the payload as it can have
-      // sensitive information. Excluding all IDENTITY/ actions because high likelyhood
-      // they contain PII and the blocklist may get out of date.
+      // Log only action type, but not the payload as it can have sensitive
+      // information or information that is not helpful for debugging. Excluding
+      // all IDENTITY/ actions because high likelyhood they contain PII and the
+      // blocklist may get out of date.
       Logger.debug('redux/saga@logger', `${action.type} (payload not logged)`)
       return
     }

From b8f4fc4fe17fbe751cbcc3dc8414831403c2f18d Mon Sep 17 00:00:00 2001
From: Kathy Luo <kathyluo18@gmail.com>
Date: Mon, 30 Sep 2024 11:40:58 +0200
Subject: [PATCH 2/2] Update src/redux/sagas.ts

Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
---
 src/redux/sagas.ts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/redux/sagas.ts b/src/redux/sagas.ts
index ca3ece3728b..b72bec6e68a 100644
--- a/src/redux/sagas.ts
+++ b/src/redux/sagas.ts
@@ -63,13 +63,13 @@ const loggerPayloadBlocklist = [
   setPhoneRecipientCache.toString(),
   updateAppRecipientCache.toString(),
   TransactionActions.UPDATE_TRANSACTIONS,
-  setTokenBalances.toString(),
-  fetchPriceHistorySuccess.toString(),
-  rewardsSendersFetched.toString(),
-  fetchDappsListCompleted.toString(),
-  fetchNftsCompleted.toString(),
-  fetchPositionsSuccess.toString(),
-  fetchShortcutsSuccess.toString(),
+  setTokenBalances.type,
+  fetchPriceHistorySuccess.type,
+  rewardsSendersFetched.type,
+  fetchDappsListCompleted.type,
+  fetchNftsCompleted.type,
+  fetchPositionsSuccess.type,
+  fetchShortcutsSuccess.type,
   AppActions.UPDATE_REMOTE_CONFIG_VALUES,
 ]