Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patches read_centroid_spectrum function #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aspect-ndujar
Copy link

@aspect-ndujar aspect-ndujar commented Apr 9, 2024

Description

When spectra have line_buffer_size larger than 1024, the read_centroid_spectrum() function in the _tsf module loops forever as it never meets the condition for breaking.
The aim of this PR is to address such situation by modifying the actual variable that needs to be increased.

Related Issue

No issue was reported previously

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant