V3 update text block formatting #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anemne
reviewed
Nov 22, 2024
anemne
reviewed
Nov 22, 2024
| @@ -17,18 +17,26 @@ export default function TextSection({ section }: TextSectionProps) { | |||
| <div className={styles.wrapper}> | |||
| <div | |||
| className={ | |||
| styles.content + | |||
| (section.textBlockType === "framed" ? ` ${styles.highlighted}` : "") | |||
| styles.content /* + | |||
There was a problem hiding this comment.
Suggested change
| styles.content /* + | |
| styles.content |
There was a problem hiding this comment.
ahh never mind! I guess this is for the frame/highlighted issue?
There was a problem hiding this comment.
Yes! I noted in the description why it was commented out and that it can be removed or added back in at a later date so we have the history and reasoning available for later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformatted the textBlock on customer case page, so that the user is limited to only using textBlock in SplitSection. Added some new styling for the highlighted textBlock option, and commented out the old styling for framed textBlock, as we are not sure if its going to be a part of the design for the customer case or not. This can be removed or added back at a later date when there is a conclusion.
The new textBlock styling, highlighted textBlock on the top:
TextBlock can only be added to splitsection in Sanity:
