Support :focus for rspec permissions blocks #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spontaneously this looks good! I'm currently enjoying Swedish vacation so I'll take a proper look in august 😊 |
StevenElberger
force-pushed
the
feature/support-rspec-focus-filter
branch
from
b5b7825
to
92c900d
Compare
Burgestrand
requested changes
Aug 7, 2024
StevenElberger
force-pushed
the
feature/support-rspec-focus-filter
branch
from
92c900d
to
36dd293
Compare
|
@Burgestrand thank you so much for your very helpful and insightful feedback! 🙇 I hope the latest changes satisfy your comments but if not please let me know! |
Burgestrand
requested changes
Aug 9, 2024
StevenElberger
force-pushed
the
feature/support-rspec-focus-filter
branch
2 times, most recently
from
766e8bc
to
3c529a8
Compare
Burgestrand
previously approved these changes
Aug 12, 2024
|
@StevenElberger rubocop caught a missing frozen string literal comment! Once you add that I believe this is ready to merge 😊 |
StevenElberger
force-pushed
the
feature/support-rspec-focus-filter
branch
from
3c529a8
to
869d066
Compare
@Burgestrand got it! should be good to go now, thank you! 😃 |
|
@StevenElberger merged, thank you! I'll see if I can get a release going with this change this month 😊 |
Burgestrand
added a commit
that referenced
this pull request
Aug 26, 2024
## Improve `NotAuthorizedError` message to include policy class (#812) Default error message changed from: > not allowed to destroy? this Comment To include the policy class: > not allowed to Project::Admin::CommentPolicy#destroy? this Comment ## Improve `NotAuthorizedError` when record is a class Before: > not allowed to index? this Class After: > not allowed to PostPolicy#index? Post ## Allow customizing rspec matcher description (#806) Before: > PostPolicy > update? and show? > is expected to permit #<User:0x0000000104aefd80> and #<Post:0x0000000104aef8d0 @user=#<User:0x0000000104aefd80>> In `spec_helper.rb`: ```ruby Pundit::RSpec::Matchers.description = ->(user, record) do "permit user with role #{user.role} to access record with ID #{record.id}" end ``` After: > PostPolicy > update? and show? > is expected to permit user with role admin to access record with ID 130 ## Add support for filter_run_when_matching :focus with permissions helper (#820) If your RSpec config has filter_run_when_matching :focus, you may tag the permissions helper like so: ```ruby permissions :show?, :focus do ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this issue would be nice to have so I took a stab at it:
#816
Please let me know if there's anything missing!