Prefer require_relative for internal requires

[tagliala]

require_relative is preferred over require for files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path.

This change updates internal requires to use require_relative for consistency, performance, and improved portability.

Refs:

• Prefer require_relative rubocop/rubocop#8748

To do

• I have read the contributing guidelines.
• I have added relevant tests.
• I have adjusted relevant documentation.
• I have made sure the individual commits are meaningful.
• I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

---

I think this does not deserve an entry in the changelog

Relevant comment: rubocop/rubocop#8748 (comment)

[Burgestrand]

Thank you for the PR. I read through the discussion in Rubocop. I didn't see any compelling arguments for why this would be better.

I'm of the opinion that relying on the load path is a Good Thing, specifically because it allows flexibility.

To be even more specific, if you for any reason wanted to prevent Pundit from loading e.g. pundit/policy_finder when we're using require, then you can do so. For example by creating ./pundit/policy_finder.rb and then $LOAD_PATH.unshift ".". Why would you want to? I don't know, but frankly I've needed this at least three times over the years, so it's an opinion I took upon through experience.

Using require_relative would strip away this flexibility, but I don't see a benefit that compensates for that loss.

I'm open to hearing solid arguments about this, but without that this is a hard pass.

[tagliala]

Thanks, can you share the concerns on the rubocop discussion? It may help others in deciding

[Burgestrand]

Thanks, can you share the concerns on the rubocop discussion? It may help others in deciding

That's a good suggestion, thank you!

[Burgestrand]

rubocop/rubocop#8748 (comment)

I wrote a comment. Thank you for the push!