Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds process exit code so that we can use this in CI #31

Merged
merged 8 commits into from
Sep 9, 2019

Conversation

Duder-onomy
Copy link
Contributor

No description provided.

@Duder-onomy
Copy link
Contributor Author

Duder-onomy commented Aug 28, 2019

This should supersede and close #30

@Duder-onomy
Copy link
Contributor Author

I can confirm that this correctly fails tests in CircleCI:
Untitled drawing

@tniezurawski
Copy link
Contributor

Nice @Duder-onomy! Thanks for that!

Could you add a paragraph to README.md about running it on CI? Just a simple example of how you've added it to your pipeline?

Adds cli argument to turn on fail on unused behavior
Adds notes to the readme to turn on behavior
@Duder-onomy
Copy link
Contributor Author

@tniezurawski I changed my mind about having this lib check if in CI directly in favor of a config variable / cli argument.

It seemed to make more sense that the person should be able to opt into this behavior directly. The whole 'if we are in ci' business is not the concern of this lib.

I added that support and updated the readme.

There is a diff in the package-lock.json that I did not intend. Simply running npm install creates that diff. I see there is a yarn.lock in the directory as well. Might make sense to switch to yarn until npm install creates deterministic builds.

@tniezurawski tniezurawski merged commit 3608373 into vastec:master Sep 9, 2019
@tniezurawski
Copy link
Contributor

Great stuff @Duder-onomy! Thanks for the work you've put into this 🙌

@tniezurawski
Copy link
Contributor

Released with 1.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants