From 7f631e88e52410504ba551785d1c4cd33791d347 Mon Sep 17 00:00:00 2001
From: Thierry <thierry@byscripts.info>
Date: Mon, 10 Jun 2024 16:31:09 +0200
Subject: [PATCH] disable ESlint rules conflicting with Prettier

---
 .eslintrc.js                                  |  8 +++---
 .../lite/src/components/AppHeader.vue         |  9 ++----
 .../lite/src/components/AppLogin.vue          |  9 ++----
 .../src/components/CollectionFilterRow.vue    |  4 +--
 .../lite/src/components/CollectionTable.vue   |  4 +--
 .../lite/src/components/NoDataError.vue       |  2 +-
 .../lite/src/components/NoResult.vue          |  2 +-
 .../src/components/PoolOverrideWarning.vue    |  2 +-
 .../component-story/StoryExampleComponent.vue |  4 +--
 .../lite/src/components/form/FormCheckbox.vue |  2 +-
 .../lite/src/components/form/FormInput.vue    |  2 +-
 .../pool/dashboard/PoolDashboardAlarms.vue    |  6 ++--
 .../src/components/ui/UiCardComingSoon.vue    |  2 +-
 .../lite/src/components/ui/UiSeparator.vue    |  2 +-
 .../lite/src/components/ui/UiStatusPanel.vue  |  2 +-
 .../lite/src/views/ObjectNotFoundView.vue     |  2 +-
 .../lite/src/views/PageNotFoundView.vue       |  2 +-
 .../lite/src/views/settings/SettingsView.vue  |  6 ++--
 .../src/views/xoa-deploy/XoaDeployView.vue    | 28 ++++++-------------
 @xen-orchestra/web/src/pages/dev/token.vue    |  2 +-
 20 files changed, 39 insertions(+), 61 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 5a2e35e621b..9992685d6bf 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -89,13 +89,13 @@ module.exports = {
         'vue/attribute-hyphenation': 'error',
         'vue/component-definition-name-casing': 'error',
         'vue/first-attribute-linebreak': 'error',
-        'vue/html-closing-bracket-newline': 'error',
+        'vue/html-closing-bracket-newline': 'off', // Conflicts with Prettier
         'vue/html-closing-bracket-spacing': 'error',
         'vue/html-end-tags': 'error',
-        'vue/html-indent': 'error',
+        'vue/html-indent': 'off', // Conflicts with Prettier
         'vue/html-quotes': 'error',
-        'vue/html-self-closing': 'error',
-        'vue/max-attributes-per-line': ['error', { singleline: 3, multiline: 1 }],
+        'vue/html-self-closing': ['error', { html: { void: 'always', normal: 'always', component: 'always' } }],
+        'vue/max-attributes-per-line': 'off', // Conflicts with Prettier
         'vue/multiline-html-element-content-newline': 'error',
         'vue/mustache-interpolation-spacing': 'error',
         'vue/no-multi-spaces': 'error',
diff --git a/@xen-orchestra/lite/src/components/AppHeader.vue b/@xen-orchestra/lite/src/components/AppHeader.vue
index 4d0c20fef03..ff031223061 100644
--- a/@xen-orchestra/lite/src/components/AppHeader.vue
+++ b/@xen-orchestra/lite/src/components/AppHeader.vue
@@ -1,13 +1,8 @@
 <template>
   <header class="app-header">
-    <UiIcon
-      v-if="isMobile"
-      ref="navigationTrigger"
-      :icon="faBars"
-      class="toggle-navigation"
-    />
+    <UiIcon v-if="isMobile" ref="navigationTrigger" :icon="faBars" class="toggle-navigation" />
     <RouterLink :to="{ name: 'home' }">
-      <img v-if="isMobile" alt="XO Lite" src="../assets/logo.svg">
+      <img v-if="isMobile" alt="XO Lite" src="../assets/logo.svg" />
       <TextLogo v-else />
     </RouterLink>
     <slot />
diff --git a/@xen-orchestra/lite/src/components/AppLogin.vue b/@xen-orchestra/lite/src/components/AppLogin.vue
index 5208399025f..90609ef6242 100644
--- a/@xen-orchestra/lite/src/components/AppLogin.vue
+++ b/@xen-orchestra/lite/src/components/AppLogin.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="app-login form-container">
     <form @submit.prevent="handleSubmit">
-      <img alt="XO Lite" src="../assets/logo-title.svg">
+      <img alt="XO Lite" src="../assets/logo-title.svg" />
       <PoolOverrideWarning />
       <p v-if="isHostIsSlaveErr(error)" class="error">
         <UiIcon :icon="faExclamationCircle" />
@@ -10,12 +10,7 @@
       </p>
       <template v-else>
         <FormInputWrapper>
-          <FormInput
-            v-model="login"
-            name="login"
-            readonly
-            type="text"
-          />
+          <FormInput v-model="login" name="login" readonly type="text" />
         </FormInputWrapper>
         <FormInput
           ref="passwordRef"
diff --git a/@xen-orchestra/lite/src/components/CollectionFilterRow.vue b/@xen-orchestra/lite/src/components/CollectionFilterRow.vue
index 7b8f6332f5d..e75fd782d09 100644
--- a/@xen-orchestra/lite/src/components/CollectionFilterRow.vue
+++ b/@xen-orchestra/lite/src/components/CollectionFilterRow.vue
@@ -2,7 +2,7 @@
   <div class="collection-filter-row">
     <span class="or">{{ $t('or') }}</span>
     <FormWidget v-if="newFilter.isAdvanced" class="form-widget-advanced">
-      <input v-model="newFilter.content">
+      <input v-model="newFilter.content" />
     </FormWidget>
     <template v-else>
       <FormWidget :before="currentFilterIcon">
@@ -29,7 +29,7 @@
         </select>
       </FormWidget>
       <FormWidget v-else-if="hasValueInput" :after="valueInputAfter" :before="valueInputBefore">
-        <input v-model="newFilter.builder.value">
+        <input v-model="newFilter.builder.value" />
       </FormWidget>
     </template>
     <UiActionButton v-if="!newFilter.isAdvanced" :icon="faPencil" @click="enableAdvancedMode" />
diff --git a/@xen-orchestra/lite/src/components/CollectionTable.vue b/@xen-orchestra/lite/src/components/CollectionTable.vue
index a8829b88ad8..aa89ef6cbe6 100644
--- a/@xen-orchestra/lite/src/components/CollectionTable.vue
+++ b/@xen-orchestra/lite/src/components/CollectionTable.vue
@@ -22,7 +22,7 @@
     <thead>
       <tr>
         <td v-if="isSelectable">
-          <input v-model="areAllSelected" type="checkbox">
+          <input v-model="areAllSelected" type="checkbox" />
         </td>
         <slot name="head-row" />
       </tr>
@@ -30,7 +30,7 @@
     <tbody>
       <tr v-for="item in filteredAndSortedCollection" :key="item.$ref">
         <td v-if="isSelectable">
-          <input v-model="selected" :value="item.$ref" type="checkbox">
+          <input v-model="selected" :value="item.$ref" type="checkbox" />
         </td>
         <slot :item name="body-row" />
       </tr>
diff --git a/@xen-orchestra/lite/src/components/NoDataError.vue b/@xen-orchestra/lite/src/components/NoDataError.vue
index 6b5f6cb8e02..decc7becc6f 100644
--- a/@xen-orchestra/lite/src/components/NoDataError.vue
+++ b/@xen-orchestra/lite/src/components/NoDataError.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="no-data">
-    <img alt="No data" class="img" src="@/assets/undraw-bug-fixing.svg">
+    <img alt="No data" class="img" src="@/assets/undraw-bug-fixing.svg" />
     <p class="text-error typo h4-medium">{{ $t('error-no-data') }}</p>
   </div>
 </template>
diff --git a/@xen-orchestra/lite/src/components/NoResult.vue b/@xen-orchestra/lite/src/components/NoResult.vue
index 7768f76bf61..7b6c417c290 100644
--- a/@xen-orchestra/lite/src/components/NoResult.vue
+++ b/@xen-orchestra/lite/src/components/NoResult.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="no-result">
-    <img alt="" class="img" src="@/assets/no-result.svg">
+    <img alt="" class="img" src="@/assets/no-result.svg" />
     <p class="text-info">{{ $t('no-result') }}</p>
   </div>
 </template>
diff --git a/@xen-orchestra/lite/src/components/PoolOverrideWarning.vue b/@xen-orchestra/lite/src/components/PoolOverrideWarning.vue
index 59e55e386cc..7dc801b8ab4 100644
--- a/@xen-orchestra/lite/src/components/PoolOverrideWarning.vue
+++ b/@xen-orchestra/lite/src/components/PoolOverrideWarning.vue
@@ -19,7 +19,7 @@
         <I18nT keypath="you-are-currently-on">
           <strong>{{ masterSessionStorage }}</strong>
         </I18nT>
-        <br>
+        <br />
         {{ $t('click-to-return-default-pool') }}
       </p>
     </div>
diff --git a/@xen-orchestra/lite/src/components/component-story/StoryExampleComponent.vue b/@xen-orchestra/lite/src/components/component-story/StoryExampleComponent.vue
index 793ea5e6123..c73ea13c332 100644
--- a/@xen-orchestra/lite/src/components/component-story/StoryExampleComponent.vue
+++ b/@xen-orchestra/lite/src/components/component-story/StoryExampleComponent.vue
@@ -18,9 +18,9 @@
     <div>Optional string prop: {{ imOptional }}</div>
     <div>Optional string prop with default: {{ imOptionalWithDefault }}</div>
     Input for default v-model:
-    <input :value="modelValue" @input="emit('update:modelValue', ($event.target as HTMLInputElement)?.value)">
+    <input :value="modelValue" @input="emit('update:modelValue', ($event.target as HTMLInputElement)?.value)" />
     Input for v-model:customModel:
-    <input :value="customModel" @input="emit('update:customModel', ($event.target as HTMLInputElement)?.value)">
+    <input :value="customModel" @input="emit('update:customModel', ($event.target as HTMLInputElement)?.value)" />
     Event with no arguments:
     <button type="button" @click="emit('click')">Click me</button>
     Event with argument:
diff --git a/@xen-orchestra/lite/src/components/form/FormCheckbox.vue b/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
index 5775b30a56b..c95d4495f2b 100644
--- a/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
+++ b/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
@@ -7,7 +7,7 @@
       :type="type === 'radio' ? 'radio' : 'checkbox'"
       class="input"
       v-bind="$attrs"
-    >
+    />
     <span class="fake-checkbox">
       <UiIcon :fixed-width="false" :icon class="icon" />
     </span>
diff --git a/@xen-orchestra/lite/src/components/form/FormInput.vue b/@xen-orchestra/lite/src/components/form/FormInput.vue
index 9b94cd51f81..ace80e341ac 100644
--- a/@xen-orchestra/lite/src/components/form/FormInput.vue
+++ b/@xen-orchestra/lite/src/components/form/FormInput.vue
@@ -38,7 +38,7 @@
       :required
       class="input"
       v-bind="$attrs"
-    >
+    />
     <span v-if="before !== undefined" class="before">
       <template v-if="typeof before === 'string'">{{ before }}</template>
       <UiIcon v-else :icon="before" class="before" />
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardAlarms.vue b/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardAlarms.vue
index af86c81a579..708505c3052 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardAlarms.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardAlarms.vue
@@ -14,7 +14,7 @@
         <UiButton @click="start">{{ $t('load-now') }}</UiButton>
       </div>
       <div>
-        <img alt="" src="@/assets/server-status.svg">
+        <img alt="" src="@/assets/server-status.svg" />
       </div>
     </div>
     <NoDataError v-else-if="hasError" />
@@ -23,9 +23,9 @@
     </div>
     <div v-else-if="alarms.length === 0" class="no-alarm">
       <div>
-        <img alt="" src="@/assets/server-status.svg">
+        <img alt="" src="@/assets/server-status.svg" />
       </div>
-      <p class="text typo h4-medium">{{ $t('all-good') }}<br>{{ $t('no-alarm-triggered') }}</p>
+      <p class="text typo h4-medium">{{ $t('all-good') }}<br />{{ $t('no-alarm-triggered') }}</p>
     </div>
     <div v-else class="table-container">
       <UiTable>
diff --git a/@xen-orchestra/lite/src/components/ui/UiCardComingSoon.vue b/@xen-orchestra/lite/src/components/ui/UiCardComingSoon.vue
index a295dc5d2e8..d8947fe20c2 100644
--- a/@xen-orchestra/lite/src/components/ui/UiCardComingSoon.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiCardComingSoon.vue
@@ -2,7 +2,7 @@
   <UiCard class="ui-card-coming-soon">
     <UiCardTitle>{{ title }}</UiCardTitle>
     <div class="content">
-      <img alt="" src="@/assets/under-construction.svg">
+      <img alt="" src="@/assets/under-construction.svg" />
     </div>
     <div class="content">{{ $t('coming-soon') }}</div>
   </UiCard>
diff --git a/@xen-orchestra/lite/src/components/ui/UiSeparator.vue b/@xen-orchestra/lite/src/components/ui/UiSeparator.vue
index 95ffe9d5fa0..e3ee9848759 100644
--- a/@xen-orchestra/lite/src/components/ui/UiSeparator.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiSeparator.vue
@@ -1,5 +1,5 @@
 <template>
-  <hr class="ui-separator">
+  <hr class="ui-separator" />
 </template>
 
 <style lang="postcss" scoped>
diff --git a/@xen-orchestra/lite/src/components/ui/UiStatusPanel.vue b/@xen-orchestra/lite/src/components/ui/UiStatusPanel.vue
index 01e7fc0c70e..74e44d6d3e7 100644
--- a/@xen-orchestra/lite/src/components/ui/UiStatusPanel.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiStatusPanel.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="ui-status-panel">
-    <img :src="imageSource" alt="" class="image">
+    <img :src="imageSource" alt="" class="image" />
     <p v-if="title !== undefined" class="title typo h2-black">{{ title }}</p>
     <p v-if="subtitle !== undefined" class="subtitle typo h3-medium">{{ subtitle }}</p>
     <slot />
diff --git a/@xen-orchestra/lite/src/views/ObjectNotFoundView.vue b/@xen-orchestra/lite/src/views/ObjectNotFoundView.vue
index 482d6f2fa29..ecf167df027 100644
--- a/@xen-orchestra/lite/src/views/ObjectNotFoundView.vue
+++ b/@xen-orchestra/lite/src/views/ObjectNotFoundView.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <img alt="Not found" src="../assets/object-not-found.svg">
+    <img alt="Not found" src="../assets/object-not-found.svg" />
     <p class="text">{{ $t('object-not-found', { id }) }}</p>
     <UiButton @click="router.push({ name: 'home' })">{{ $t('back-pool-dashboard') }}</UiButton>
   </div>
diff --git a/@xen-orchestra/lite/src/views/PageNotFoundView.vue b/@xen-orchestra/lite/src/views/PageNotFoundView.vue
index da5aee9346b..4076f837396 100644
--- a/@xen-orchestra/lite/src/views/PageNotFoundView.vue
+++ b/@xen-orchestra/lite/src/views/PageNotFoundView.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <img alt="Not found" src="../assets/page-not-found.svg">
+    <img alt="Not found" src="../assets/page-not-found.svg" />
     <p class="numeric">404</p>
     <p class="text">{{ $t('page-not-found') }}</p>
     <UiButton @click="router.push({ name: 'home' })">{{ $t('back-pool-dashboard') }}</UiButton>
diff --git a/@xen-orchestra/lite/src/views/settings/SettingsView.vue b/@xen-orchestra/lite/src/views/settings/SettingsView.vue
index 27b8cb86643..e6fda4c04ec 100644
--- a/@xen-orchestra/lite/src/views/settings/SettingsView.vue
+++ b/@xen-orchestra/lite/src/views/settings/SettingsView.vue
@@ -85,9 +85,9 @@
           :class="{ selected: colorMode === colorModeOption }"
           @click="colorMode = colorModeOption"
         >
-          <img v-if="colorModeOption === 'light'" src="@/assets/color-mode-light.svg" alt="Color mode light">
-          <img v-else-if="colorModeOption === 'dark'" src="@/assets/color-mode-dark.svg" alt="Color mode dark">
-          <img v-else src="@/assets/color-mode-auto.svg" alt="Color mode auto">
+          <img v-if="colorModeOption === 'light'" src="@/assets/color-mode-light.svg" alt="Color mode light" />
+          <img v-else-if="colorModeOption === 'dark'" src="@/assets/color-mode-dark.svg" alt="Color mode dark" />
+          <img v-else src="@/assets/color-mode-auto.svg" alt="Color mode auto" />
           <span>
             <UiIcon v-if="colorMode === colorModeOption" :icon="faCheck" />
             {{ $t(`theme-${colorModeOption}`) }}
diff --git a/@xen-orchestra/lite/src/views/xoa-deploy/XoaDeployView.vue b/@xen-orchestra/lite/src/views/xoa-deploy/XoaDeployView.vue
index 18da75e3f41..d4cae86cad2 100644
--- a/@xen-orchestra/lite/src/views/xoa-deploy/XoaDeployView.vue
+++ b/@xen-orchestra/lite/src/views/xoa-deploy/XoaDeployView.vue
@@ -1,7 +1,7 @@
 <template>
   <TitleBar :icon="faDownload">{{ $t('deploy-xoa') }}</TitleBar>
   <div v-if="deploying" class="status">
-    <img src="@/assets/xo.svg" width="300" alt="Xen Orchestra">
+    <img src="@/assets/xo.svg" width="300" alt="Xen Orchestra" />
 
     <!-- Error -->
     <template v-if="error !== undefined">
@@ -40,12 +40,7 @@
         <UiIcon :icon="faExclamationCircle" />
         {{ $t('keep-page-open') }}
       </p>
-      <UiButton
-        :disabled="vmRef === undefined"
-        color="error"
-        level="secondary"
-        @click="cancel()"
-      >
+      <UiButton :disabled="vmRef === undefined" color="error" level="secondary" @click="cancel()">
         {{ $t('cancel') }}
       </UiButton>
     </template>
@@ -146,23 +141,13 @@
               :label="$t('admin-password')"
               learn-more-url="https://xen-orchestra.com/docs/xoa.html#default-xo-account"
             >
-              <FormInput
-                v-model="xoaPwd"
-                type="password"
-                required
-                :placeholder="$t('password')"
-              />
+              <FormInput v-model="xoaPwd" type="password" required :placeholder="$t('password')" />
             </FormInputWrapper>
             <FormInputWrapper
               :label="$t('admin-password-confirm')"
               learn-more-url="https://xen-orchestra.com/docs/xoa.html#default-xo-account"
             >
-              <FormInput
-                v-model="xoaPwdConfirm"
-                type="password"
-                required
-                :placeholder="$t('password')"
-              />
+              <FormInput v-model="xoaPwdConfirm" type="password" required :placeholder="$t('password')" />
             </FormInputWrapper>
           </div>
         </FormSection>
@@ -170,7 +155,10 @@
         <FormSection :label="$t('xoa-ssh-account')">
           <div class="row">
             <FormInputWrapper :label="$t('ssh-account')">
-              <label><span>{{ $t('disabled') }}</span><FormToggle v-model="enableSshAccount" /><span>{{ $t('enabled') }}</span></label>
+              <label
+                ><span>{{ $t('disabled') }}</span
+                ><FormToggle v-model="enableSshAccount" /><span>{{ $t('enabled') }}</span></label
+              >
             </FormInputWrapper>
           </div>
           <div class="row">
diff --git a/@xen-orchestra/web/src/pages/dev/token.vue b/@xen-orchestra/web/src/pages/dev/token.vue
index 85435172aa6..e1249e61aee 100644
--- a/@xen-orchestra/web/src/pages/dev/token.vue
+++ b/@xen-orchestra/web/src/pages/dev/token.vue
@@ -2,7 +2,7 @@
   <div class="token">
     <form @submit.prevent="handleSubmit">
       Enter XO 5 token:
-      <input v-model="token">
+      <input v-model="token" />
       <button type="submit">Register token</button>
     </form>