Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker arbitrary argument #89

Open
gaow opened this issue Apr 29, 2020 · 4 comments
Open

Docker arbitrary argument #89

gaow opened this issue Apr 29, 2020 · 4 comments
Assignees

Comments

@gaow
Copy link
Member

gaow commented Apr 29, 2020

I have a docker image that only works with an additional option -e HOME=/seqlink. That is, the docker command should be:

docker run ... -e HOME=/seqlink ...

But currently it does not seem we can add this information to allow for these options. What should I do for this case?

@BoPeng
Copy link
Contributor

BoPeng commented Apr 29, 2020

Did you try environment='HOME=/seqlink'? environment={'HOME': '/seqlink'} should also work.

@BoPeng
Copy link
Contributor

BoPeng commented Apr 29, 2020

I will move the ticket to sos-docs if the option works. Options that need to be documented include environment, mem_limit, volumes_from, port, name, stdin_open, tty, user, extra_args. I think only volumes is documented.

@gaow
Copy link
Member Author

gaow commented Apr 29, 2020

@BoPeng thank you it does work! Yes let's move this ticket to sos-doc repo.

@BoPeng BoPeng transferred this issue from vatlab/sos Apr 29, 2020
@BoPeng
Copy link
Contributor

BoPeng commented May 6, 2020

@joannfeng Good way for you to learn docker. Basically you need to set things up and be able to run examples in https://github.com/vatlab/sos-docs/blob/master/src/user_guide/docker.ipynb (check out this repo, open src/user_guide/docker.ipynb, and run).

Then have a look at https://github.com/vatlab/sos/blob/master/src/sos/docker/client.py#L312 and you can figure out there are parameters that not documented.

Add one or sections on how to use these parameters, refer to https://docs.docker.com/engine/reference/run/ if needed.

Create a PR for additional documentation on this tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants