-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop side panel from moving #127
Comments
Since it's jQuery, wouldn't setting draggable and resizable to 'disable' remove the ability to resize and/or drag the panel around? This way, there could possibly be an addition in the future to add something like a checkbox that could allow the user to enable or disable those properties as required. eg:
|
The problem I had was that when I edit something in the input field of the side panel and would like to select some test with mouse (e.g. copy/paste), the panel could be dragged. So I think,
|
The problem might be something to do with the interaction with CodeMirror. CodeMirror has a CodeMirror-focused class that is active when the text editor is focused. When you click the drop-down panel near an input field, that class is removed from the element and this lets the user drag the panel. I will submit the PR shortly, but would it be possible to leave the issue open so point #1 of your response can be done in the near future? |
I will prefer a PR that solves problem 1. In this way we can keep graggability but disallow unintended drag. |
Disabling draggability on the side panel temporarily until issue vatlab#127 can be addressed in a better way as suggested
Ah, okay. My mistake, I saw your reply after I submitted the PR. I'll look at problem 1 then. |
I haven't been able to replicate it, but I'll take a look at this and the draggability as well and get back to you if I find a suitable solution. |
The screenshot was for the latest sos notebook on a mac machine with chrome. It might pertain only to chrome. |
I couldn't replicate the issue on a Windows machine with Firefox. It's probably an issue with Chrome and WebKit that can be handled with JS. I'll look into it and update here if I find anything good. |
A new console interface will be used, which should move around. #150 |
It is possible to move side panel around, which has caused some trouble when I select text from the input area. It is probably good enough to fix the side panel to the side.
The text was updated successfully, but these errors were encountered: