Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest Faraday #918

Open
olleolleolle opened this issue Jan 11, 2022 · 4 comments
Open

Support latest Faraday #918

olleolleolle opened this issue Jan 11, 2022 · 4 comments

Comments

@olleolleolle
Copy link
Member

olleolleolle commented Jan 11, 2022

CI runs now indicate that we need to accommodate latest Faraday.

Ideal situation is that we support Faraday 1.x and Faraday 2.x for at least a period of time.

This happens on all runs, all Rubies.

Update: Clarification, this is about the config.hook_into :faraday middleware.

If you use webmock, you are unaffected.

@andrehjr
Copy link
Contributor

I took a look into this the other day, I think I can help move this forward @olleolleolle 🙌

For Faraday 2.0 I think it needs to be addressed on Typhoeus typhoeus/typhoeus#686 🤔

@mattbrictson
Copy link
Contributor

I have been using vcr with faraday 2.0 for over a month now with no problems. What am I missing? Does it depend on the adapter being used?

@mattbrictson
Copy link
Contributor

Ah, I see. I didn't realize vcr has some sort of custom faraday middleware that is activated with hook_into :faraday. I have been using webmock with vcr and faraday 2.0 and it works fine.

config.hook_into :webmock

@olleolleolle
Copy link
Member Author

@mattbrictson Thanks for the workaround note, I amended the Description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants