Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Host' header for webmock hook and ::Excon presence condition #936

Open
alekseyl-workato opened this issue Apr 26, 2022 · 0 comments
Open

Comments

@alekseyl-workato
Copy link

alekseyl-workato commented Apr 26, 2022

'Host' header for webmock is deleted only when ::Excon present, but if we do not care about Host here for 'excon', we should not care for the Host header at all because not only excon will add the 'Host' header, here is stl Net::HTTPGenericRequest source code adding 'Host' header from url

This will lead to an issue: whenever excon is added or removed to/from the dependencies -- recorded headers will have/miss 'Host' header which in case of full headers matching will fail all checks.

@alekseyl-workato alekseyl-workato changed the title Host header for webmock hook and Excon condition 'Host' header for webmock hook and ::Excon presence condition Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant