Replace HeaderDowncaser with Hash#transform_keys #1015
Merged
+3
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VCR dropping support for Ruby 2.4 allows a VCR specific module, HeaderDowncaser, to be replaced by a Ruby standard library call Hash#transform_keys. I didn't find any unit tests specific to the module but the support module was used throughout the RSpec test suite. Reference Ruby 2.5 introduced Hash#transform_keys https://docs.ruby-lang.org/en/3.2/NEWS/NEWS-2_5_0.html Close: vcr#1012
olleolleolle
approved these changes
Feb 21, 2024
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Thanks, @notapatch 🙏 Good one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCR dropping support for Ruby 2.4 allows a VCR specific module, HeaderDowncaser, to be replaced by a Ruby standard library call Hash#transform_keys.
I didn't find any unit tests specific to the module but the support module was used throughout the RSpec test suite.
Reference
Ruby 2.5 introduced Hash#transform_keys
https://docs.ruby-lang.org/en/3.2/NEWS/NEWS-2_5_0.html
Close: #1012