Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to turn VCR on and off in a new thread #1019

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aglundahl
Copy link

@aglundahl aglundahl commented Jul 4, 2024

#764 fixed so that VCR's :turned_off status for the main thread can be read in a new thread, even if the status changes after the new thread was created.

However, the solution also introduced the problem that the :turned_off status isn't used for other threads than the main thread. This effectively makes it impossible to turn VCR on and off in a new thread.

This change, instead, creates new contexts with :turned_off and :ignore_cassettes set to nil by default. When the values are read, they are only used if they explicitly have been set on the thread's context. Otherwise the main thread's context is used.

35c5186 fixed so that VCR's `:turned_off` status for the main thread can be read
in a new thread, even if the status changes after the new thread was created.

However, the solution also introduced the problem that the `:turned_off` status
isn't used for other threads than the main thread. This effectively makes it
impossible to turn VCR on and off in a new thread.

This change, instead, creates new contexts with `:turned_off` and
`:ignore_cassettes` set to `nil` by default. When the values are read, they are
only used if they explicitly have been set on the thread's context. Otherwise
the main thread's context is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant