Make it possible to turn VCR on and off in a new thread #1019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#764 fixed so that VCR's
:turned_off
status for the main thread can be read in a new thread, even if the status changes after the new thread was created.However, the solution also introduced the problem that the
:turned_off
status isn't used for other threads than the main thread. This effectively makes it impossible to turn VCR on and off in a new thread.This change, instead, creates new contexts with
:turned_off
and:ignore_cassettes
set tonil
by default. When the values are read, they are only used if they explicitly have been set on the thread's context. Otherwise the main thread's context is used.