Make VCR CI compatible with Faraday 1 and 2 #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a great start, and I thank you for it! I think it looks good and I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took a stab into making specs run against faraday 1 and 2. In the past, this repo was using https://github.com/thoughtbot/appraisal for stuff like this, It's also an option.
But If we want only to test against faraday 2, I can rework this PR and remove the faraday 1.x stuff.
I was also thinking about having the same strategy to support newer rack versions, while keeping compatibility 🤔 What do you think?
This closes #1001