-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where a URI with a duplicate of the same param does not allow a match for the same URI #602
base: master
Are you sure you want to change the base?
Conversation
Thanks so much for posting this fix! It really helped us with our project. Any chance this can make its way into master? |
@kcdragon I know this has taken a long time, but can you please update from master? |
Hi @krainboltgreene |
Hello, @kcdragon! Master changed, again, what does this PR look like, rebased, now? Thanks for your continued perseverance! |
725f983
to
ff4eb59
Compare
@olleolleolle I rebased with master and its passing locally for me now. The build is failing though. It looks like the build server is choosing version webmock isn't locked on anything in gemspec so I'm guessing you want to allow any version (including old versions) of this dependency? I see a couple options if we don't want to require a version greater than
Let me know your thoughts. |
@olleolleolle I thought a little bit more about this and I'm now thinking it would be pretty reasonable to require webmock >= |
ff4eb59
to
6282858
Compare
6282858
to
1007ab2
Compare
…ow a match for the same URI See issue vcr#515
1007ab2
to
1023d98
Compare
@olleolleolle I'm coming back around to this now. I pushed the change I mentioned in #602 (comment). The build is now failing with
It looks like the version of Typhoeus being with Gemfile.typhoeus-0.4 doesn't have a method needed in the newer version of webmock. I'm guessing a patch for that method could be added here lib/vcr/library_hooks/typhoeus_0.4.rb but I'm wondering if it makes more sense to drop support for typhoeus 0.4. It looks like it was expected to be dropped anyway a couple major versions ago https://github.com/vcr/vcr/blob/master/lib/vcr/library_hooks/typhoeus_0.4.rb#L101. Let me know your thoughts. |
@kcdragon Thanks for the detailed report, and the details. Yes, we should use a Typhoeus + webmock which is up-to-date. Dropping Ye Olde Versions is alright by me. |
See issue #515
A couple things to note about this fix.
allow_duplicate_query_string_params
that modified the WebMockquery_values_notation
if VCR config option was true (we set it to false by default). Let me know your thoughts on whether this should be a config option or always in place.