fix!(QueryList): Generic fixes #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 62.64% 62.67% +0.02%
==========================================
Files 39 39
Lines 3443 3445 +2
Branches 927 927
==========================================
+ Hits 2157 2159 +2
Misses 770 770
Partials 516 516 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
query-list-typings
branch
from
4bb25cd to
4097b09
Compare
src/libvcs/_internal/query_list.py:307: error: List comprehension has incompatible type List[tuple[Any, T]]; expected List[T] [misc] src/libvcs/_internal/query_list.py:376: error: Incompatible types in assignment (expression has type "Callable[[str | list[Any]], bool]", variable has type "Callable[[T], bool]") [assignment]
tests/_internal/test_query_list.py:262: error: Argument 1 to "filter" of "QueryList" has incompatible type "Mapping[str, str | list[str]]"; expected "Callable[[dict[str, Any]], bool] | dict[str, Any] | None" [arg-type] tests/_internal/test_query_list.py:275: error: Argument 1 to "get" of "QueryList" has incompatible type "Mapping[str, str | list[str]] | None"; expected "Callable[[dict[str, Any]], bool] | dict[str, Any] | None" [arg-type] tests/_internal/test_query_list.py:281: error: Argument 1 to "get" of "QueryList" has incompatible type "Mapping[str, str | list[str]] | None"; expected "Callable[[dict[str, Any]], bool] | dict[str, Any] | None" [arg-type] tests/_internal/test_query_list.py:288: error: Argument 1 to "get" of "QueryList" has incompatible type "Mapping[str, str | list[str]] | None"; expected "Callable[[dict[str, Any]], bool] | dict[str, Any] | None" [arg-type]
tony
force-pushed
the
query-list-typings
branch
from
4097b09 to
e12b880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: tmux-python/libtmux#515
Changes
QueryList