-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RightPanel navigation is unintuitive, especially with threads #19660
Comments
I also think a big part of this is #17376 when looking into spaces |
ah yup, 100%. |
To clarify on the whole "should threads stay open when you change rooms" thing:
Now, if you want to have a thread visible while switching between rooms, i think we need a separate mechanism to pin that thread in a PIP much as we do for voice/video conferences. (Or alternatively threads could be those in the first place, rather than being in the RightPanel). |
Though, I think it makes perfect sense to show space members when exploring rooms of that space, just not to miss that case :D |
To add to this comment, I'd like to to advocate heavily for us to figure out how to let Threads persist when switching rooms:
I realise in today's model (and proposal) threads are effectively children of specific rooms, but I'm struggling to use them in practise. @daniellekirkwood @janogarcia let me know if you'd prefer me to file an adjacent, explicit, issue for that request! |
I'm also struggling to use threads much in practice (finding it very hard to know when psychologically to start a thread rather than a reply, especially when reply is hardcoded muscle memory), although lack of notifs are a big factor there. Separately: we have worst of both worlds currently when switching rooms - if you look at threads in your current room, you then get shown in the new room if you switch room (even if you don't care about them). I think the right solution here would be to give a way to pin threads outside of the RightPanel if you want to keep them around as you flit between rooms, tbh. |
Thanks for the comments! @nadonomy Yes, let's create an issue that is Threads specific and talks specifically to the use case of how to persist a chosen thread in the right panel (it might well be Matthew's idea of Pinning, but let's not put the solution into the problem). This is not something that will be in the MVP/P0 version of Threads but is something we can definitely look into. As for the rest of this issue, @janogarcia has a great breakdown so I will let them respond to address the rest. |
I really think that there shouldn't be a "thread" button and a "reply" button. Instead there should be a single button, which should always add your message to the thread; and it should show it on the main TL, or not show it, based on different factors which could also be discussed. |
Replies and threads have different purposes. You might have a preference for one thing but I don't think everyone will feel the same way about it, so condensing both into one feels like a not so great idea... This also feels like a separate issue |
I don't think that replies have any purpose that can't be covered just as well by threads.
I don't know. I just brought it up because Matthew said he wasn't using threads much because it's hard to decide whether to use a thread or a reply. My point is the user shouldn't even need to make that decision. |
We’ve been discussing internally most of these issues regarding the right panel. It's clear that it's in need of a major overhaul. As for the threads panel, it hasn’t introduced any new behavior to the right panel, it’s basically following the existing conventions for it, and by doing so it’s making more evident the current design flaws of the right panel: the back navigation button’s behavior, the panel status persistence behavior when switching rooms... I’m sharing here for reference the immediate plan of action for the Threads P0 epic that we discussed internally. We can explore more in-depth other issues and implementations outside the scope of Threads P0.
|
We as widget developers are very excited about this new maximized widgets feature. Thanks for making this happen! |
@skolmer sorry for reading this just now. But yes this is the case. You can use the "set room layout for everyone" button (if you have permission to do so in the room) and it will also apply the maximised layout. |
@daniellekirkwood Adding some relevant comment from a recent discussion with @toger5. Timo suggested a model where "if the right panel is open each change that triggers the right panel will just be appended to the navigation history" and "if the right panel is closed and the right panel is triggered by some ui action a default history will be created and set to the right panel:". I'm copying my feedback and recommendations below: I’ve been thinking a lot on these and many other workarounds for the current right panel behavior. I wouldn’t recommend tracking the history as proposed (i.e. keep track of all history if panel is open, reset history once it’s closed). There’s no easy way back home That’s my main concern when taking that approach. The room header buttons toggle the right panel, those won’t take you to each section initial view (as it happens for example in the navigation bar of a mobile app). For example, if the right panel is already open showing a user profile and then you click on a thread summary in the main timeline, the thread replaces the user profile view and the back button will be pointing to that user profile you were viewing. Now, if you need to navigate to the thread list you’d need to, unintuitively, click on the thread icon in the room header to hide the thread panel and then click on it again to display it in its default state. Benchmarking There’s plenty of examples of products that have faced exactly the same limitations when trying to handle all the sidebar contents with a single container: Slack, Rocket.Chat, Mattermost, Flowdock, Chanty… An example of an app that’s taking a different approach is Discord. They circumvent the limitations of a single, shared right sidebar by separating concerns and using independent, floating containers (i.e. popover windows and modals) for each area: Mentions and Unreads, Pinned Messages, Threads, User Profiles... Short-term solution As I suggested in the original discussion on the current right panel issues, we should focus — at least in the short term — on mitigating the most pressing ones and handle those one by one. I know it’s not an ideal solution, or an elegant one to implement and maintain. My current recommendation is to keep using/traversing the hierarchical navigation tree as much as possible, so that you can always easily reach the initial state for that panel by going up in the hierarchy. So, for example you can always traverse this navigation path in both directions:
For the particular case of viewing user profiles when in the context of a thread, and then be able to go back to thread, we could handle it in two different ways:
Long-term solution As suggested in the original discussion we should explore alternative approaches as part of a larger redesign of the app navigation and architecture, but those changes are more involved and far reaching than the current scope for the Threads P0 milestone. We could explore making use of detached containers ala Discord (popover windows and modals), or maybe consider tabs (or stacks) so that we have more than one sidebar container/slot that can coexist without stepping on top of each other. |
@daniellekirkwood Also relevant to this discussion: recommended labels for the Back button. |
Forgot to add another approach worth mentioning as a long-term solution, which should be relatively easy to implement now that @toger5 has added support for tracking per-room right panel navigation history. ProblemThe core issue with the current navigation model for the right panel is that the back button is trying to handle both hierarchical and history navigation, which is never going to work, as those will always end up clashing, leading to: Easily broken right panel history As long as you interact exclusively with actions contained in the right panel, a back button that tracks history makes sense (i.e. every new state of the panel was triggered by the immediately preceding state), but as soon as the panel state is modified in reaction to an event happening outside of it, the back button history will be kind of broken. For example, clicking on an avatar or thread summary in the main timeline will reset the back button history and make it work hierarchically — because otherwise there wouldn't be an "easy way back home" as explained below — and thus we're breaking the contract for the back button, which sometimes would be pointing to the history but under some other circumstances would be pointing to a hardcoded navigation path (hierarchical). There’s no easy way back home As mentioned in my previous comment, there's no optimal way to get back to the initial state for each section (e.g. reaching the Thread List when viewing a Thread, or the Room Info when viewing a User Profile...) or traverse the hierarchy (e.g. going up in the Room Info navigation path
SolutionA possible universal, long-term solution that works for any context. By separating concerns for historical and hierarchical navigation we could avoid such clashes altogether, and effectively address all the issues above, in a scalable and future-proof way (i.e. without needing to hardcode a lot of exceptions and interdependent navigation paths). A relative easy implementation would consist of:
|
* Add permission dropdown for sending reactions ([\element-hq#7492](matrix-org/matrix-react-sdk#7492)). Fixes element-hq#20450. * Ship maximised widgets and remove feature flag ([\element-hq#7509](matrix-org/matrix-react-sdk#7509)). * Properly maintain aspect ratio of inline images ([\element-hq#7503](matrix-org/matrix-react-sdk#7503)). * Add zoom buttons to the location view ([\element-hq#7482](matrix-org/matrix-react-sdk#7482)). * Remove bubble from around location events ([\element-hq#7459](matrix-org/matrix-react-sdk#7459)). Fixes element-hq#20323. * Disable "Publish this room" option in invite only rooms ([\element-hq#7441](matrix-org/matrix-react-sdk#7441)). Fixes element-hq#6596. Contributed by @aaronraimist. * Give secret key field an `id` ([\element-hq#7489](matrix-org/matrix-react-sdk#7489)). Fixes element-hq#20390. Contributed by @SimonBrandner. * Display a tooltip when you hover over a location ([\element-hq#7472](matrix-org/matrix-react-sdk#7472)). * Open map in a dialog when it is clicked ([\element-hq#7465](matrix-org/matrix-react-sdk#7465)). * a11y - wrap notification level radios in fieldsets ([\element-hq#7471](matrix-org/matrix-react-sdk#7471)). * Wrap inputs in fieldsets in Space visibility settings ([\element-hq#7350](matrix-org/matrix-react-sdk#7350)). * History based navigation with new right panel store ([\element-hq#7398](matrix-org/matrix-react-sdk#7398)). Fixes element-hq#19686 element-hq#19660 and element-hq#19634. * Associate room alias warning with public option in settings ([\element-hq#7430](matrix-org/matrix-react-sdk#7430)). * Disable quick reactions button when no permissions ([\element-hq#7412](matrix-org/matrix-react-sdk#7412)). Fixes element-hq#20270. * Allow opening a map view in OpenStreetMap ([\element-hq#7428](matrix-org/matrix-react-sdk#7428)). * Display the user's avatar when they shared their location ([\element-hq#7424](matrix-org/matrix-react-sdk#7424)). * Remove the Forward and Share buttons for location messages only ([\element-hq#7423](matrix-org/matrix-react-sdk#7423)). * Add configuration to disable relative date markers in timeline ([\element-hq#7405](matrix-org/matrix-react-sdk#7405)). * Space preferences for whether or not you see DMs in a Space ([\element-hq#7250](matrix-org/matrix-react-sdk#7250)). Fixes element-hq#19529 and element-hq#19955. * Have LocalEchoWrapper emit updates so the app can react faster ([\#7358](matrix-org/matrix-react-sdk#7358)). Fixes element-hq#19749. * Use semantic heading on dialog component ([\element-hq#7383](matrix-org/matrix-react-sdk#7383)). * Add `/jumptodate` slash command ([\element-hq#7372](matrix-org/matrix-react-sdk#7372)). Fixes element-hq#7677. * Update room context menu copy ([\element-hq#7361](matrix-org/matrix-react-sdk#7361)). Fixes element-hq#20133. * Use lazy rendering in the AddExistingToSpaceDialog ([\element-hq#7369](matrix-org/matrix-react-sdk#7369)). Fixes element-hq#18784. * Tweak FacePile tooltip to include whether or not you are included ([\element-hq#7367](matrix-org/matrix-react-sdk#7367)). Fixes element-hq#17278. * Ensure group audio-only calls don't switch on the webcam on join ([\element-hq#20234](element-hq#20234)). Fixes element-hq#20212. * Fix wrongly wrapping code blocks, breaking line numbers ([\element-hq#7507](matrix-org/matrix-react-sdk#7507)). Fixes element-hq#20316. * Set header buttons to no phase when right panel is closed ([\element-hq#7506](matrix-org/matrix-react-sdk#7506)). * Fix active Jitsi calls (and other active widgets) not being visible on screen, by showing them in PiP if they are not visible in any other container ([\element-hq#7435](matrix-org/matrix-react-sdk#7435)). Fixes element-hq#15169 and element-hq#20275. * Fix layout of message bubble preview in settings ([\element-hq#7497](matrix-org/matrix-react-sdk#7497)). * Prevent mutations of js-sdk owned objects as it breaks accountData ([\element-hq#7504](matrix-org/matrix-react-sdk#7504)). Fixes matrix-org/element-web-rageshakes#7822. * fallback properly with pluralized strings ([\element-hq#7495](matrix-org/matrix-react-sdk#7495)). Fixes element-hq#20455. * Consider continuations when resolving whether a tile is last in section ([\element-hq#7461](matrix-org/matrix-react-sdk#7461)). Fixes element-hq#20368 and element-hq#20369. * Fix read receipts and sent indicators for bubble layout ([\element-hq#7460](matrix-org/matrix-react-sdk#7460)). Fixes element-hq#18298 and element-hq#20345. * null-guard dataset mxTheme to prevent html exports from exploding ([\element-hq#7493](matrix-org/matrix-react-sdk#7493)). Fixes element-hq#20453. * Fix avatar container overlapping give feedback cta ([\element-hq#7491](matrix-org/matrix-react-sdk#7491)). Fixes matrix-org/element-web-rageshakes#7987. * Fix jump to bottom button working when on a permalink ([\element-hq#7494](matrix-org/matrix-react-sdk#7494)). Fixes element-hq#19813. * Remove the Description from the location picker ([\element-hq#7485](matrix-org/matrix-react-sdk#7485)). * Fix look of the untrusted device dialog ([\#7487](matrix-org/matrix-react-sdk#7487)). Fixes element-hq#20447. Contributed by @SimonBrandner. * Hide maximise button in the sticker picker ([\element-hq#7488](matrix-org/matrix-react-sdk#7488)). Fixes element-hq#20443. Contributed by @SimonBrandner. * Fix space ordering to match newer spec ([\element-hq#7481](matrix-org/matrix-react-sdk#7481)). * Fix typing notification colors ([\element-hq#7490](matrix-org/matrix-react-sdk#7490)). Fixes element-hq#20144. Contributed by @SimonBrandner. * fix fallback for pluralized strings ([\element-hq#7480](matrix-org/matrix-react-sdk#7480)). Fixes element-hq#20426. * Fix right panel soft crashes chat rooms ([\element-hq#7479](matrix-org/matrix-react-sdk#7479)). Fixes element-hq#20433. * update yarn.lock and i18n ([\element-hq#7476](matrix-org/matrix-react-sdk#7476)). Fixes element-hq#20426 and element-hq#20423. * Don't send typing notification when restoring composer draft ([\element-hq#7477](matrix-org/matrix-react-sdk#7477)). Fixes element-hq#20424. * Fix room joining spinner being incorrect if you change room mid-join ([\element-hq#7473](matrix-org/matrix-react-sdk#7473)). * Only return the approved widget capabilities instead of accepting all requested capabilities ([\element-hq#7454](matrix-org/matrix-react-sdk#7454)). Contributed by @dhenneke. * Fix quoting messages from the search view ([\element-hq#7466](matrix-org/matrix-react-sdk#7466)). Fixes element-hq#20353. * Attribute fallback i18n strings with lang attribute ([\element-hq#7323](matrix-org/matrix-react-sdk#7323)). * Fix spotlight cmd-k wrongly expanding left panel ([\element-hq#7463](matrix-org/matrix-react-sdk#7463)). Fixes element-hq#20399. * Fix room_id check when adding user widgets ([\element-hq#7448](matrix-org/matrix-react-sdk#7448)). Fixes element-hq#19382. Contributed by @bink. * Add new line in settings label ([\element-hq#7451](matrix-org/matrix-react-sdk#7451)). Fixes element-hq#20365. * Fix handling incoming redactions in EventIndex ([\element-hq#7443](matrix-org/matrix-react-sdk#7443)). Fixes element-hq#19326. * Fix room alias address isn't checked for validity before being shown as added ([\element-hq#7107](matrix-org/matrix-react-sdk#7107)). Fixes element-hq#19609. Contributed by @Palid. * Call view accessibility fixes ([\element-hq#7439](matrix-org/matrix-react-sdk#7439)). Fixes element-hq#18516. * Fix offscreen canvas breaking with split-brained firefox support ([\element-hq#7440](matrix-org/matrix-react-sdk#7440)). * Removed red shield in forwarding preview. ([\element-hq#7447](matrix-org/matrix-react-sdk#7447)). Contributed by @ankur12-1610. * Wrap status message ([\element-hq#7325](matrix-org/matrix-react-sdk#7325)). Fixes element-hq#20092. Contributed by @SimonBrandner. * Move hideSender logic into state so it causes re-render ([\element-hq#7413](matrix-org/matrix-react-sdk#7413)). Fixes element-hq#18448. * Fix dialpad positioning ([\element-hq#7446](matrix-org/matrix-react-sdk#7446)). Fixes element-hq#20175. Contributed by @SimonBrandner. * Hide non-functional list options on Suggested sublist ([\element-hq#7410](matrix-org/matrix-react-sdk#7410)). Fixes element-hq#20252. * Fix width overflow in mini composer overflow menu ([\element-hq#7411](matrix-org/matrix-react-sdk#7411)). Fixes element-hq#20263. * Fix being wrongly sent to Home space when creating/joining/leaving rooms ([\element-hq#7418](matrix-org/matrix-react-sdk#7418)). Fixes matrix-org/element-web-rageshakes#7331 element-hq#20246 and element-hq#20240. * Fix HTML Export where the data-mx-theme is `Light` not `light` ([\element-hq#7415](matrix-org/matrix-react-sdk#7415)). * Don't disable username/password fields whilst doing wk-lookup ([\element-hq#7438](matrix-org/matrix-react-sdk#7438)). Fixes element-hq#20121. * Prevent keyboard propagation out of context menus ([\element-hq#7437](matrix-org/matrix-react-sdk#7437)). Fixes element-hq#20317. * Fix nulls leaking into geo urls ([\element-hq#7433](matrix-org/matrix-react-sdk#7433)). * Fix zIndex of peristent apps in miniMode ([\element-hq#7429](matrix-org/matrix-react-sdk#7429)). * Space panel should watch spaces for space name changes ([\element-hq#7432](matrix-org/matrix-react-sdk#7432)). * Fix list formatting alternating on edit ([\element-hq#7422](matrix-org/matrix-react-sdk#7422)). Fixes element-hq#20073. Contributed by @renancleyson-dev. * Don't show `Testing small changes` without UIFeature.Feedback ([\element-hq#7427](matrix-org/matrix-react-sdk#7427)). Fixes element-hq#20298. * Fix invisible toggle space panel button ([\element-hq#7426](matrix-org/matrix-react-sdk#7426)). Fixes element-hq#20279. * Fix legacy breadcrumbs wrongly showing up ([\element-hq#7425](matrix-org/matrix-react-sdk#7425)). * Space Panel use SettingsStore instead of SpaceStore as source of truth ([\element-hq#7404](matrix-org/matrix-react-sdk#7404)). Fixes element-hq#20250. * Fix inline code block nowrap issue ([\element-hq#7406](matrix-org/matrix-react-sdk#7406)). * Fix notification badge for All Rooms space ([\element-hq#7401](matrix-org/matrix-react-sdk#7401)). Fixes element-hq#20229. * Show error if could not load space hierarchy ([\element-hq#7399](matrix-org/matrix-react-sdk#7399)). Fixes element-hq#20221. * Increase gap between ELS and the subsequent event to prevent overlap ([\element-hq#7391](matrix-org/matrix-react-sdk#7391)). Fixes element-hq#18319. * Fix list of members in space preview ([\element-hq#7356](matrix-org/matrix-react-sdk#7356)). Fixes element-hq#19781. * Fix sizing of e2e shield in bubble layout ([\element-hq#7394](matrix-org/matrix-react-sdk#7394)). Fixes element-hq#19090. * Fix bubble radius wrong when followed by a state event from same user ([\element-hq#7393](matrix-org/matrix-react-sdk#7393)). Fixes element-hq#18982. * Fix alignment between ELS and Events in bubble layout ([\element-hq#7392](matrix-org/matrix-react-sdk#7392)). Fixes element-hq#19652 and element-hq#19057. * Don't include the accuracy parameter in location events if accuracy could not be determined. ([\element-hq#7375](matrix-org/matrix-react-sdk#7375)). * Make compact layout only apply to Modern layout ([\element-hq#7382](matrix-org/matrix-react-sdk#7382)). Fixes element-hq#18412. * Pin qrcode to fix e2e verification bug ([\element-hq#7378](matrix-org/matrix-react-sdk#7378)). Fixes element-hq#20188. * Add internationalisation to progress strings in room export dialog ([\element-hq#7385](matrix-org/matrix-react-sdk#7385)). Fixes element-hq#20208. * Prevent escape to cancel edit from also scrolling to bottom ([\element-hq#7380](matrix-org/matrix-react-sdk#7380)). Fixes element-hq#20182. * Fix narrow mode composer buttons for polls labs ([\element-hq#7386](matrix-org/matrix-react-sdk#7386)). Fixes element-hq#20067. * Fix useUserStatusMessage exploding on unknown user ([\element-hq#7365](matrix-org/matrix-react-sdk#7365)). * Fix room join spinner in room list header ([\element-hq#7364](matrix-org/matrix-react-sdk#7364)). Fixes element-hq#20139. * Fix room search sometimes not opening spotlight ([\element-hq#7363](matrix-org/matrix-react-sdk#7363)). Fixes matrix-org/element-web-rageshakes#7288.
* Add permission dropdown for sending reactions ([\#7492](matrix-org/matrix-react-sdk#7492)). Fixes element-hq/element-web#20450. * Ship maximised widgets and remove feature flag ([\#7509](matrix-org/matrix-react-sdk#7509)). * Properly maintain aspect ratio of inline images ([\#7503](matrix-org/matrix-react-sdk#7503)). * Add zoom buttons to the location view ([\#7482](matrix-org/matrix-react-sdk#7482)). * Remove bubble from around location events ([\#7459](matrix-org/matrix-react-sdk#7459)). Fixes element-hq/element-web#20323. * Disable "Publish this room" option in invite only rooms ([\#7441](matrix-org/matrix-react-sdk#7441)). Fixes element-hq/element-web#6596. Contributed by @aaronraimist. * Give secret key field an `id` ([\#7489](matrix-org/matrix-react-sdk#7489)). Fixes element-hq/element-web#20390. Contributed by @SimonBrandner. * Display a tooltip when you hover over a location ([\#7472](matrix-org/matrix-react-sdk#7472)). * Open map in a dialog when it is clicked ([\#7465](matrix-org/matrix-react-sdk#7465)). * a11y - wrap notification level radios in fieldsets ([\#7471](matrix-org/matrix-react-sdk#7471)). * Wrap inputs in fieldsets in Space visibility settings ([\#7350](matrix-org/matrix-react-sdk#7350)). * History based navigation with new right panel store ([\#7398](matrix-org/matrix-react-sdk#7398)). Fixes element-hq/element-web#19686 element-hq/element-web#19660 and element-hq/element-web#19634. * Associate room alias warning with public option in settings ([\#7430](matrix-org/matrix-react-sdk#7430)). * Disable quick reactions button when no permissions ([\#7412](matrix-org/matrix-react-sdk#7412)). Fixes element-hq/element-web#20270. * Allow opening a map view in OpenStreetMap ([\#7428](matrix-org/matrix-react-sdk#7428)). * Display the user's avatar when they shared their location ([\#7424](matrix-org/matrix-react-sdk#7424)). * Remove the Forward and Share buttons for location messages only ([\#7423](matrix-org/matrix-react-sdk#7423)). * Add configuration to disable relative date markers in timeline ([\#7405](matrix-org/matrix-react-sdk#7405)). * Space preferences for whether or not you see DMs in a Space ([\#7250](matrix-org/matrix-react-sdk#7250)). Fixes element-hq/element-web#19529 and element-hq/element-web#19955. * Have LocalEchoWrapper emit updates so the app can react faster ([\#7358](matrix-org/matrix-react-sdk#7358)). Fixes element-hq/element-web#19749. * Use semantic heading on dialog component ([\#7383](matrix-org/matrix-react-sdk#7383)). * Add `/jumptodate` slash command ([\#7372](matrix-org/matrix-react-sdk#7372)). Fixes element-hq/element-web#7677. * Update room context menu copy ([\#7361](matrix-org/matrix-react-sdk#7361)). Fixes element-hq/element-web#20133. * Use lazy rendering in the AddExistingToSpaceDialog ([\#7369](matrix-org/matrix-react-sdk#7369)). Fixes element-hq/element-web#18784. * Tweak FacePile tooltip to include whether or not you are included ([\#7367](matrix-org/matrix-react-sdk#7367)). Fixes element-hq/element-web#17278. * Ensure group audio-only calls don't switch on the webcam on join ([\#20234](element-hq/element-web#20234)). Fixes element-hq/element-web#20212. * Fix wrongly wrapping code blocks, breaking line numbers ([\#7507](matrix-org/matrix-react-sdk#7507)). Fixes element-hq/element-web#20316. * Set header buttons to no phase when right panel is closed ([\#7506](matrix-org/matrix-react-sdk#7506)). * Fix active Jitsi calls (and other active widgets) not being visible on screen, by showing them in PiP if they are not visible in any other container ([\#7435](matrix-org/matrix-react-sdk#7435)). Fixes element-hq/element-web#15169 and element-hq/element-web#20275. * Fix layout of message bubble preview in settings ([\#7497](matrix-org/matrix-react-sdk#7497)). * Prevent mutations of js-sdk owned objects as it breaks accountData ([\#7504](matrix-org/matrix-react-sdk#7504)). Fixes matrix-org/element-web-rageshakes#7822. * fallback properly with pluralized strings ([\#7495](matrix-org/matrix-react-sdk#7495)). Fixes element-hq/element-web#20455. * Consider continuations when resolving whether a tile is last in section ([\#7461](matrix-org/matrix-react-sdk#7461)). Fixes element-hq/element-web#20368 and element-hq/element-web#20369. * Fix read receipts and sent indicators for bubble layout ([\#7460](matrix-org/matrix-react-sdk#7460)). Fixes element-hq/element-web#18298 and element-hq/element-web#20345. * null-guard dataset mxTheme to prevent html exports from exploding ([\#7493](matrix-org/matrix-react-sdk#7493)). Fixes element-hq/element-web#20453. * Fix avatar container overlapping give feedback cta ([\#7491](matrix-org/matrix-react-sdk#7491)). Fixes matrix-org/element-web-rageshakes#7987. * Fix jump to bottom button working when on a permalink ([\#7494](matrix-org/matrix-react-sdk#7494)). Fixes element-hq/element-web#19813. * Remove the Description from the location picker ([\#7485](matrix-org/matrix-react-sdk#7485)). * Fix look of the untrusted device dialog ([\#7487](matrix-org/matrix-react-sdk#7487)). Fixes element-hq/element-web#20447. Contributed by @SimonBrandner. * Hide maximise button in the sticker picker ([\#7488](matrix-org/matrix-react-sdk#7488)). Fixes element-hq/element-web#20443. Contributed by @SimonBrandner. * Fix space ordering to match newer spec ([\#7481](matrix-org/matrix-react-sdk#7481)). * Fix typing notification colors ([\#7490](matrix-org/matrix-react-sdk#7490)). Fixes element-hq/element-web#20144. Contributed by @SimonBrandner. * fix fallback for pluralized strings ([\#7480](matrix-org/matrix-react-sdk#7480)). Fixes element-hq/element-web#20426. * Fix right panel soft crashes chat rooms ([\#7479](matrix-org/matrix-react-sdk#7479)). Fixes element-hq/element-web#20433. * update yarn.lock and i18n ([\#7476](matrix-org/matrix-react-sdk#7476)). Fixes element-hq/element-web#20426 and element-hq/element-web#20423. * Don't send typing notification when restoring composer draft ([\#7477](matrix-org/matrix-react-sdk#7477)). Fixes element-hq/element-web#20424. * Fix room joining spinner being incorrect if you change room mid-join ([\#7473](matrix-org/matrix-react-sdk#7473)). * Only return the approved widget capabilities instead of accepting all requested capabilities ([\#7454](matrix-org/matrix-react-sdk#7454)). Contributed by @dhenneke. * Fix quoting messages from the search view ([\#7466](matrix-org/matrix-react-sdk#7466)). Fixes element-hq/element-web#20353. * Attribute fallback i18n strings with lang attribute ([\#7323](matrix-org/matrix-react-sdk#7323)). * Fix spotlight cmd-k wrongly expanding left panel ([\#7463](matrix-org/matrix-react-sdk#7463)). Fixes element-hq/element-web#20399. * Fix room_id check when adding user widgets ([\#7448](matrix-org/matrix-react-sdk#7448)). Fixes element-hq/element-web#19382. Contributed by @bink. * Add new line in settings label ([\#7451](matrix-org/matrix-react-sdk#7451)). Fixes element-hq/element-web#20365. * Fix handling incoming redactions in EventIndex ([\#7443](matrix-org/matrix-react-sdk#7443)). Fixes element-hq/element-web#19326. * Fix room alias address isn't checked for validity before being shown as added ([\#7107](matrix-org/matrix-react-sdk#7107)). Fixes element-hq/element-web#19609. Contributed by @Palid. * Call view accessibility fixes ([\#7439](matrix-org/matrix-react-sdk#7439)). Fixes element-hq/element-web#18516. * Fix offscreen canvas breaking with split-brained firefox support ([\#7440](matrix-org/matrix-react-sdk#7440)). * Removed red shield in forwarding preview. ([\#7447](matrix-org/matrix-react-sdk#7447)). Contributed by @ankur12-1610. * Wrap status message ([\#7325](matrix-org/matrix-react-sdk#7325)). Fixes element-hq/element-web#20092. Contributed by @SimonBrandner. * Move hideSender logic into state so it causes re-render ([\#7413](matrix-org/matrix-react-sdk#7413)). Fixes element-hq/element-web#18448. * Fix dialpad positioning ([\#7446](matrix-org/matrix-react-sdk#7446)). Fixes element-hq/element-web#20175. Contributed by @SimonBrandner. * Hide non-functional list options on Suggested sublist ([\#7410](matrix-org/matrix-react-sdk#7410)). Fixes element-hq/element-web#20252. * Fix width overflow in mini composer overflow menu ([\#7411](matrix-org/matrix-react-sdk#7411)). Fixes element-hq/element-web#20263. * Fix being wrongly sent to Home space when creating/joining/leaving rooms ([\#7418](matrix-org/matrix-react-sdk#7418)). Fixes matrix-org/element-web-rageshakes#7331 element-hq/element-web#20246 and element-hq/element-web#20240. * Fix HTML Export where the data-mx-theme is `Light` not `light` ([\#7415](matrix-org/matrix-react-sdk#7415)). * Don't disable username/password fields whilst doing wk-lookup ([\#7438](matrix-org/matrix-react-sdk#7438)). Fixes element-hq/element-web#20121. * Prevent keyboard propagation out of context menus ([\#7437](matrix-org/matrix-react-sdk#7437)). Fixes element-hq/element-web#20317. * Fix nulls leaking into geo urls ([\#7433](matrix-org/matrix-react-sdk#7433)). * Fix zIndex of peristent apps in miniMode ([\#7429](matrix-org/matrix-react-sdk#7429)). * Space panel should watch spaces for space name changes ([\#7432](matrix-org/matrix-react-sdk#7432)). * Fix list formatting alternating on edit ([\#7422](matrix-org/matrix-react-sdk#7422)). Fixes element-hq/element-web#20073. Contributed by @renancleyson-dev. * Don't show `Testing small changes` without UIFeature.Feedback ([\#7427](matrix-org/matrix-react-sdk#7427)). Fixes element-hq/element-web#20298. * Fix invisible toggle space panel button ([\#7426](matrix-org/matrix-react-sdk#7426)). Fixes element-hq/element-web#20279. * Fix legacy breadcrumbs wrongly showing up ([\#7425](matrix-org/matrix-react-sdk#7425)). * Space Panel use SettingsStore instead of SpaceStore as source of truth ([\#7404](matrix-org/matrix-react-sdk#7404)). Fixes element-hq/element-web#20250. * Fix inline code block nowrap issue ([\#7406](matrix-org/matrix-react-sdk#7406)). * Fix notification badge for All Rooms space ([\#7401](matrix-org/matrix-react-sdk#7401)). Fixes element-hq/element-web#20229. * Show error if could not load space hierarchy ([\#7399](matrix-org/matrix-react-sdk#7399)). Fixes element-hq/element-web#20221. * Increase gap between ELS and the subsequent event to prevent overlap ([\#7391](matrix-org/matrix-react-sdk#7391)). Fixes element-hq/element-web#18319. * Fix list of members in space preview ([\#7356](matrix-org/matrix-react-sdk#7356)). Fixes element-hq/element-web#19781. * Fix sizing of e2e shield in bubble layout ([\#7394](matrix-org/matrix-react-sdk#7394)). Fixes element-hq/element-web#19090. * Fix bubble radius wrong when followed by a state event from same user ([\#7393](matrix-org/matrix-react-sdk#7393)). Fixes element-hq/element-web#18982. * Fix alignment between ELS and Events in bubble layout ([\#7392](matrix-org/matrix-react-sdk#7392)). Fixes element-hq/element-web#19652 and element-hq/element-web#19057. * Don't include the accuracy parameter in location events if accuracy could not be determined. ([\#7375](matrix-org/matrix-react-sdk#7375)). * Make compact layout only apply to Modern layout ([\#7382](matrix-org/matrix-react-sdk#7382)). Fixes element-hq/element-web#18412. * Pin qrcode to fix e2e verification bug ([\#7378](matrix-org/matrix-react-sdk#7378)). Fixes element-hq/element-web#20188. * Add internationalisation to progress strings in room export dialog ([\#7385](matrix-org/matrix-react-sdk#7385)). Fixes element-hq/element-web#20208. * Prevent escape to cancel edit from also scrolling to bottom ([\#7380](matrix-org/matrix-react-sdk#7380)). Fixes element-hq/element-web#20182. * Fix narrow mode composer buttons for polls labs ([\#7386](matrix-org/matrix-react-sdk#7386)). Fixes element-hq/element-web#20067. * Fix useUserStatusMessage exploding on unknown user ([\#7365](matrix-org/matrix-react-sdk#7365)). * Fix room join spinner in room list header ([\#7364](matrix-org/matrix-react-sdk#7364)). Fixes element-hq/element-web#20139. * Fix room search sometimes not opening spotlight ([\#7363](matrix-org/matrix-react-sdk#7363)). Fixes matrix-org/element-web-rageshakes#7288.
* Add permission dropdown for sending reactions ([\matrix-org#7492](matrix-org#7492)). Fixes element-hq/element-web#20450. * Ship maximised widgets and remove feature flag ([\matrix-org#7509](matrix-org#7509)). * Properly maintain aspect ratio of inline images ([\matrix-org#7503](matrix-org#7503)). * Add zoom buttons to the location view ([\matrix-org#7482](matrix-org#7482)). * Remove bubble from around location events ([\matrix-org#7459](matrix-org#7459)). Fixes element-hq/element-web#20323. * Disable "Publish this room" option in invite only rooms ([\matrix-org#7441](matrix-org#7441)). Fixes element-hq/element-web#6596. Contributed by @aaronraimist. * Give secret key field an `id` ([\matrix-org#7489](matrix-org#7489)). Fixes element-hq/element-web#20390. Contributed by @SimonBrandner. * Display a tooltip when you hover over a location ([\matrix-org#7472](matrix-org#7472)). * Open map in a dialog when it is clicked ([\matrix-org#7465](matrix-org#7465)). * a11y - wrap notification level radios in fieldsets ([\matrix-org#7471](matrix-org#7471)). * Wrap inputs in fieldsets in Space visibility settings ([\matrix-org#7350](matrix-org#7350)). * History based navigation with new right panel store ([\matrix-org#7398](matrix-org#7398)). Fixes element-hq/element-web#19686 element-hq/element-web#19660 and element-hq/element-web#19634. * Associate room alias warning with public option in settings ([\matrix-org#7430](matrix-org#7430)). * Disable quick reactions button when no permissions ([\matrix-org#7412](matrix-org#7412)). Fixes element-hq/element-web#20270. * Allow opening a map view in OpenStreetMap ([\matrix-org#7428](matrix-org#7428)). * Display the user's avatar when they shared their location ([\matrix-org#7424](matrix-org#7424)). * Remove the Forward and Share buttons for location messages only ([\matrix-org#7423](matrix-org#7423)). * Add configuration to disable relative date markers in timeline ([\matrix-org#7405](matrix-org#7405)). * Space preferences for whether or not you see DMs in a Space ([\matrix-org#7250](matrix-org#7250)). Fixes element-hq/element-web#19529 and element-hq/element-web#19955. * Have LocalEchoWrapper emit updates so the app can react faster ([\matrix-org#7358](matrix-org#7358)). Fixes element-hq/element-web#19749. * Use semantic heading on dialog component ([\matrix-org#7383](matrix-org#7383)). * Add `/jumptodate` slash command ([\matrix-org#7372](matrix-org#7372)). Fixes element-hq/element-web#7677. * Update room context menu copy ([\matrix-org#7361](matrix-org#7361)). Fixes element-hq/element-web#20133. * Use lazy rendering in the AddExistingToSpaceDialog ([\matrix-org#7369](matrix-org#7369)). Fixes element-hq/element-web#18784. * Tweak FacePile tooltip to include whether or not you are included ([\matrix-org#7367](matrix-org#7367)). Fixes element-hq/element-web#17278. * Fix wrongly wrapping code blocks, breaking line numbers ([\matrix-org#7507](matrix-org#7507)). Fixes element-hq/element-web#20316. * Set header buttons to no phase when right panel is closed ([\matrix-org#7506](matrix-org#7506)). * Fix active Jitsi calls (and other active widgets) not being visible on screen, by showing them in PiP if they are not visible in any other container ([\matrix-org#7435](matrix-org#7435)). Fixes element-hq/element-web#15169 and element-hq/element-web#20275. * Fix layout of message bubble preview in settings ([\matrix-org#7497](matrix-org#7497)). * Prevent mutations of js-sdk owned objects as it breaks accountData ([\matrix-org#7504](matrix-org#7504)). Fixes matrix-org/element-web-rageshakes#7822. * fallback properly with pluralized strings ([\matrix-org#7495](matrix-org#7495)). Fixes element-hq/element-web#20455. * Consider continuations when resolving whether a tile is last in section ([\matrix-org#7461](matrix-org#7461)). Fixes element-hq/element-web#20368 and element-hq/element-web#20369. * Fix read receipts and sent indicators for bubble layout ([\matrix-org#7460](matrix-org#7460)). Fixes element-hq/element-web#18298 and element-hq/element-web#20345. * null-guard dataset mxTheme to prevent html exports from exploding ([\matrix-org#7493](matrix-org#7493)). Fixes element-hq/element-web#20453. * Fix avatar container overlapping give feedback cta ([\matrix-org#7491](matrix-org#7491)). Fixes matrix-org/element-web-rageshakes#7987. * Fix jump to bottom button working when on a permalink ([\matrix-org#7494](matrix-org#7494)). Fixes element-hq/element-web#19813. * Remove the Description from the location picker ([\matrix-org#7485](matrix-org#7485)). * Fix look of the untrusted device dialog ([\matrix-org#7487](matrix-org#7487)). Fixes element-hq/element-web#20447. Contributed by @SimonBrandner. * Hide maximise button in the sticker picker ([\matrix-org#7488](matrix-org#7488)). Fixes element-hq/element-web#20443. Contributed by @SimonBrandner. * Fix space ordering to match newer spec ([\matrix-org#7481](matrix-org#7481)). * Fix typing notification colors ([\matrix-org#7490](matrix-org#7490)). Fixes element-hq/element-web#20144. Contributed by @SimonBrandner. * fix fallback for pluralized strings ([\matrix-org#7480](matrix-org#7480)). Fixes element-hq/element-web#20426. * Fix right panel soft crashes chat rooms ([\matrix-org#7479](matrix-org#7479)). Fixes element-hq/element-web#20433. * update yarn.lock and i18n ([\matrix-org#7476](matrix-org#7476)). Fixes element-hq/element-web#20426 and element-hq/element-web#20423. * Don't send typing notification when restoring composer draft ([\matrix-org#7477](matrix-org#7477)). Fixes element-hq/element-web#20424. * Fix room joining spinner being incorrect if you change room mid-join ([\matrix-org#7473](matrix-org#7473)). * Only return the approved widget capabilities instead of accepting all requested capabilities ([\matrix-org#7454](matrix-org#7454)). Contributed by @dhenneke. * Fix quoting messages from the search view ([\matrix-org#7466](matrix-org#7466)). Fixes element-hq/element-web#20353. * Attribute fallback i18n strings with lang attribute ([\matrix-org#7323](matrix-org#7323)). * Fix spotlight cmd-k wrongly expanding left panel ([\matrix-org#7463](matrix-org#7463)). Fixes element-hq/element-web#20399. * Fix room_id check when adding user widgets ([\matrix-org#7448](matrix-org#7448)). Fixes element-hq/element-web#19382. Contributed by @bink. * Add new line in settings label ([\matrix-org#7451](matrix-org#7451)). Fixes element-hq/element-web#20365. * Fix handling incoming redactions in EventIndex ([\matrix-org#7443](matrix-org#7443)). Fixes element-hq/element-web#19326. * Fix room alias address isn't checked for validity before being shown as added ([\matrix-org#7107](matrix-org#7107)). Fixes element-hq/element-web#19609. Contributed by @Palid. * Call view accessibility fixes ([\matrix-org#7439](matrix-org#7439)). Fixes element-hq/element-web#18516. * Fix offscreen canvas breaking with split-brained firefox support ([\matrix-org#7440](matrix-org#7440)). * Removed red shield in forwarding preview. ([\matrix-org#7447](matrix-org#7447)). Contributed by @ankur12-1610. * Wrap status message ([\matrix-org#7325](matrix-org#7325)). Fixes element-hq/element-web#20092. Contributed by @SimonBrandner. * Move hideSender logic into state so it causes re-render ([\matrix-org#7413](matrix-org#7413)). Fixes element-hq/element-web#18448. * Fix dialpad positioning ([\matrix-org#7446](matrix-org#7446)). Fixes element-hq/element-web#20175. Contributed by @SimonBrandner. * Hide non-functional list options on Suggested sublist ([\matrix-org#7410](matrix-org#7410)). Fixes element-hq/element-web#20252. * Fix width overflow in mini composer overflow menu ([\matrix-org#7411](matrix-org#7411)). Fixes element-hq/element-web#20263. * Fix being wrongly sent to Home space when creating/joining/leaving rooms ([\matrix-org#7418](matrix-org#7418)). Fixes matrix-org/element-web-rageshakes#7331 element-hq/element-web#20246 and element-hq/element-web#20240. * Fix HTML Export where the data-mx-theme is `Light` not `light` ([\matrix-org#7415](matrix-org#7415)). * Don't disable username/password fields whilst doing wk-lookup ([\matrix-org#7438](matrix-org#7438)). Fixes element-hq/element-web#20121. * Prevent keyboard propagation out of context menus ([\matrix-org#7437](matrix-org#7437)). Fixes element-hq/element-web#20317. * Fix nulls leaking into geo urls ([\matrix-org#7433](matrix-org#7433)). * Fix zIndex of peristent apps in miniMode ([\matrix-org#7429](matrix-org#7429)). * Space panel should watch spaces for space name changes ([\matrix-org#7432](matrix-org#7432)). * Fix list formatting alternating on edit ([\matrix-org#7422](matrix-org#7422)). Fixes element-hq/element-web#20073. Contributed by @renancleyson-dev. * Don't show `Testing small changes` without UIFeature.Feedback ([\matrix-org#7427](matrix-org#7427)). Fixes element-hq/element-web#20298. * Fix invisible toggle space panel button ([\matrix-org#7426](matrix-org#7426)). Fixes element-hq/element-web#20279. * Fix legacy breadcrumbs wrongly showing up ([\matrix-org#7425](matrix-org#7425)). * Space Panel use SettingsStore instead of SpaceStore as source of truth ([\matrix-org#7404](matrix-org#7404)). Fixes element-hq/element-web#20250. * Fix inline code block nowrap issue ([\matrix-org#7406](matrix-org#7406)). * Fix notification badge for All Rooms space ([\matrix-org#7401](matrix-org#7401)). Fixes element-hq/element-web#20229. * Show error if could not load space hierarchy ([\matrix-org#7399](matrix-org#7399)). Fixes element-hq/element-web#20221. * Increase gap between ELS and the subsequent event to prevent overlap ([\matrix-org#7391](matrix-org#7391)). Fixes element-hq/element-web#18319. * Fix list of members in space preview ([\matrix-org#7356](matrix-org#7356)). Fixes element-hq/element-web#19781. * Fix sizing of e2e shield in bubble layout ([\matrix-org#7394](matrix-org#7394)). Fixes element-hq/element-web#19090. * Fix bubble radius wrong when followed by a state event from same user ([\matrix-org#7393](matrix-org#7393)). Fixes element-hq/element-web#18982. * Fix alignment between ELS and Events in bubble layout ([\matrix-org#7392](matrix-org#7392)). Fixes element-hq/element-web#19652 and element-hq/element-web#19057. * Don't include the accuracy parameter in location events if accuracy could not be determined. ([\matrix-org#7375](matrix-org#7375)). * Make compact layout only apply to Modern layout ([\matrix-org#7382](matrix-org#7382)). Fixes element-hq/element-web#18412. * Pin qrcode to fix e2e verification bug ([\matrix-org#7378](matrix-org#7378)). Fixes element-hq/element-web#20188. * Add internationalisation to progress strings in room export dialog ([\matrix-org#7385](matrix-org#7385)). Fixes element-hq/element-web#20208. * Prevent escape to cancel edit from also scrolling to bottom ([\matrix-org#7380](matrix-org#7380)). Fixes element-hq/element-web#20182. * Fix narrow mode composer buttons for polls labs ([\matrix-org#7386](matrix-org#7386)). Fixes element-hq/element-web#20067. * Fix useUserStatusMessage exploding on unknown user ([\matrix-org#7365](matrix-org#7365)). * Fix room join spinner in room list header ([\matrix-org#7364](matrix-org#7364)). Fixes element-hq/element-web#20139. * Fix room search sometimes not opening spotlight ([\matrix-org#7363](matrix-org#7363)). Fixes matrix-org/element-web-rageshakes#7288.
Steps to reproduce
While dogfooding threads I'm finding the RightPanel behaviour very unintuitive. Problems include:
The text was updated successfully, but these errors were encountered: