Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitter sunsetting: ensure hidden highlights code respects MSC3946 #24324

Closed
Tracked by #24262
Johennes opened this issue Jan 25, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#10088
Closed
Tracked by #24262
Assignees
Labels
T-Task Tasks for the team like planning Team: App Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc

Comments

@Johennes
Copy link
Contributor

Johennes commented Jan 25, 2023

Adapt the code inside RoomView to call findPredecessor instead of manually extracting room predecessor from the create event.

Pass through the MSC3946 feature flag to findPredecessor to ensure it has the correct behaviour.

@Johennes Johennes added T-Task Tasks for the team like planning Team: App labels Jan 25, 2023
@Johennes Johennes changed the title Use findPredecessor in RoomView Gitter sunsetting: Use findPredecessor in RoomView Jan 25, 2023
@andybalaam
Copy link
Member

Chatting to Eric this morning, #24325 seems more urgent.

Meanwhile, testing RoomView is proving very annoying, so putting this on hold and picking up 24325

@andybalaam andybalaam assigned weeman1337 and unassigned andybalaam Feb 3, 2023
@andybalaam
Copy link
Member

I looked at this briefly and found testing RoomView tricky. Feel free to give me a ping if you'd like to talk it through.

@andybalaam andybalaam changed the title Gitter sunsetting: Use findPredecessor in RoomView Gitter sunsetting: ensure hidden highlights code respects MSC3946 Feb 3, 2023
@andybalaam
Copy link
Member

This change only affects whether you see "hidden highlights": notifications from an old room. This does not seem important enough to block Gitter sunsetting.

@MadLittleMods MadLittleMods added the Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Team: App Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants