Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new room UI by default on develop.element.io #26089

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Enable new room UI by default on develop.element.io #26089

merged 2 commits into from
Sep 15, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 31, 2023 •
edited by github-actions bot
Loading

As discussed with @Johennes and @daniellekirkwood

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Fixes: #26116

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg mentioned this pull request Aug 31, 2023
Closed
7 tasks
@germain-gg germain-gg added the T-Task Tasks for the team like planning label Aug 31, 2023
@germain-gg germain-gg marked this pull request as ready for review September 1, 2023 15:19
@germain-gg germain-gg requested a review from a team as a code owner September 1, 2023 15:19
@t3chguy
Copy link
Member

t3chguy commented Sep 1, 2023

Blocked by #26090

@richvdh richvdh changed the title Enable new room UI by default on develop Enable new room UI by default on develop.element.io Sep 4, 2023
@andybalaam andybalaam marked this pull request as draft September 4, 2023 14:31
@andybalaam
Copy link
Member

Pausing this for now - some more work is needed first.

@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2023

Also blocked by #26105

@Johennes
Copy link
Contributor

#26105 has been fixed and #26090 only strikes when the knocking labs flag is turned on now. Other MVP room header issues have also been fixed. So this seems ready to go ahead now.

@Johennes Johennes marked this pull request as ready for review September 15, 2023 07:14
@Johennes Johennes merged commit df6b106 into develop Sep 15, 2023
19 of 20 checks passed
@Johennes Johennes deleted the germain-gg/room-ui-develop branch September 15, 2023 13:22
@Johennes Johennes mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable new room UI by default on develop
5 participants
@germain-gg @t3chguy @andybalaam @Johennes @richvdh