chore(deps): bump trust-dns-proto from 0.20.4 to 0.21.1 #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [trust-dns-proto](https://github.com/bluejekyll/trust-dns) from 0.20.4 to 0.21.1. - [Release notes](https://github.com/bluejekyll/trust-dns/releases) - [Changelog](https://github.com/bluejekyll/trust-dns/blob/main/CHANGELOG.md) - [Commits](bluejekyll/trust-dns@v0.20.4...v0.21.1) --- updated-dependencies: - dependency-name: trust-dns-proto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: a29eec9 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/621e585f69e85b0007f5aea1 😎 Browse the preview: https://deploy-preview-11604--vector-project.netlify.app/reports/lighthouse |
jszwedko
approved these changes
Feb 28, 2022
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
github-actions
bot
added
the
domain: sources
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
reviewed
Feb 28, 2022
| ); | ||
|
|
||
| self.insert( | ||
| self.event_schema | ||
| .dns_query_header_schema() | ||
| .authority_count(), | ||
| header.authority_count as i64, |
There was a problem hiding this comment.
I removed most of these as i64s because Event already implements From for most numeric types (which just calls as i64).
| }), | ||
| }, | ||
| dns_message::RTYPE_MB => { | ||
| let mut decoder = self.get_rdata_decoder_with_raw_message(rdata.anything()); |
There was a problem hiding this comment.
This was the bulk of the changes here. RData#anything was changed to not return an Option. Instead Record#data returns an Option<RData> (you can see the corresponding change above around 152).
https://github.com/bluejekyll/trust-dns/pull/1626
It's not really clear to me when there would be no record data, but the end result should be preserved that we just bubble up an error.
Comment on lines
851
to
853
| option => Err(DnsMessageParserError::UnknownEdnsOption { | ||
| option: option.clone(), | ||
| }), |
There was a problem hiding this comment.
They made this enum non-exhaustive. If they do add another member, then we would need to handle it. Rust is adding a lint for this, but it isn't stable yet: rust-lang/rust#89554
There was a problem hiding this comment.
Actually, I was able to handle the unknown options generically in 9ec889d which improves this. Ideally, we'd still get compiler warnings if they add a new variant, but this at least removes the error I was previously bubbling up.
|
@spencergilbert I made enough changes here that it probably warrants another set of 👀 if you wouldn't mind taking a peek. |
This reverts commit bc8db62.
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Soak Test ResultsBaseline: 82264fa ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±5%:
Fine details of change detection per experiment.
Fine details of each soak run.
|
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
spencergilbert
approved these changes
Mar 1, 2022
…ust-dns-proto-0.21.1
Soak Test ResultsBaseline: 635ddcc ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±5%:
Fine details of change detection per experiment.
Fine details of each soak run.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps trust-dns-proto from 0.20.4 to 0.21.1.
Release notes
Sourced from trust-dns-proto's releases.
... (truncated)
Changelog
Sourced from trust-dns-proto's changelog.
... (truncated)
Commits
7e4f9b2prepare 0.21.1 release312b8abfix resolve build with dns over rustls47713ccremove depdabot tag0d577f1bump enum-as-inner to 0.4cca5155prepare 0.21.0 for release3eeee75cleanup trust-dns-util to not always enable openssl4929738fix clippy warnings for 1.59.0e22a7e7remove structopt dependency59b9711deprecate outdated dnssec algorithms13998d5Parse DS records (#1635)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)