From 2e7322e5409e62e83c69b209eca9688076bf0601 Mon Sep 17 00:00:00 2001 From: Doug Smith Date: Fri, 27 Oct 2023 16:44:10 -0400 Subject: [PATCH 1/5] OPW-94 deprecate obsolete http metrics --- docs/DEPRECATIONS.md | 4 ++++ .../2023-11-07-0-34-0-upgrade-guide.md | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/docs/DEPRECATIONS.md b/docs/DEPRECATIONS.md index 83a39131027ab..2fc5aef3a58ec 100644 --- a/docs/DEPRECATIONS.md +++ b/docs/DEPRECATIONS.md @@ -6,6 +6,10 @@ See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating t ## To be removed +### 0.34.0 * Support for `v1` series endpoint in the `datadog_metrics` sink should be removed. * legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed * armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl) + +### 0.35.0 +* `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics \ No newline at end of file diff --git a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md index 96ec22414075b..f30303b61338b 100644 --- a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md +++ b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md @@ -14,6 +14,10 @@ Vector's 0.34.0 release includes **breaking changes**: 1. [Removal of Deprecated Datadog Component Config Options](#datadog-deprecated-config-options) 1. [Removal of Deprecated `component_name` Metric Tag](#deprecated-component-name) +and **deprecations**: + +1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprcate-obsolete-http-metrics) + We cover them below to help you upgrade quickly: ## Upgrade guide @@ -31,3 +35,15 @@ been removed from the Enterprise configuration. Instead of `region`, `site` shou #### Removal of Deprecated `component_name` Metric Tag {#deprecated-component-name} The deprecated `component_name` tag has been removed from all internal metrics. Instead the `component_id` tag should be used. + +### Deprecations + +#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprcate-obsolete-http-metrics} + +The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics will be removed in the 0.35.0 release. + +| Deprecated Metric | Replacement Metric | Affected Components | +|-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------| +| requests_completed_total | http_client_responses_total | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape | +| request_duration_seconds | http_client_response_rtt_seconds | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape | +| requests_received_total | http_server_requests_received_total | aws kinesis firehose, heroku logplex, prometheus exporter, splunk hec | \ No newline at end of file From a471c590bca37ac02a139fc1f85164d106fc4134 Mon Sep 17 00:00:00 2001 From: Doug Smith Date: Mon, 30 Oct 2023 15:04:27 -0400 Subject: [PATCH 2/5] feedback --- .../en/highlights/2023-11-07-0-34-0-upgrade-guide.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md index f30303b61338b..6c93711e49c5f 100644 --- a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md +++ b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md @@ -16,7 +16,7 @@ Vector's 0.34.0 release includes **breaking changes**: and **deprecations**: -1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprcate-obsolete-http-metrics) +1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprecate-obsolete-http-metrics) We cover them below to help you upgrade quickly: @@ -38,11 +38,11 @@ The deprecated `component_name` tag has been removed from all internal metrics. ### Deprecations -#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprcate-obsolete-http-metrics} +#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprecate-obsolete-http-metrics} The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics will be removed in the 0.35.0 release. -| Deprecated Metric | Replacement Metric | Affected Components | +| Deprecated metric | Replacement metric | Affected components | |-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------| | requests_completed_total | http_client_responses_total | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape | | request_duration_seconds | http_client_response_rtt_seconds | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape | From e8c5079df80a8ac432700951531fa68c0c71ad98 Mon Sep 17 00:00:00 2001 From: Doug Smith Date: Mon, 30 Oct 2023 15:06:32 -0400 Subject: [PATCH 3/5] feedback --- .../content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md index 6c93711e49c5f..0ac107236c0f9 100644 --- a/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md +++ b/website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md @@ -40,7 +40,7 @@ The deprecated `component_name` tag has been removed from all internal metrics. #### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprecate-obsolete-http-metrics} -The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics will be removed in the 0.35.0 release. +The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics are removed in the 0.35.0 release. | Deprecated metric | Replacement metric | Affected components | |-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------| From bfab42115627647c83f503999ceefe85a8fe8907 Mon Sep 17 00:00:00 2001 From: Doug Smith Date: Tue, 31 Oct 2023 15:07:11 -0400 Subject: [PATCH 4/5] fmt --- docs/DEPRECATIONS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/DEPRECATIONS.md b/docs/DEPRECATIONS.md index 2fc5aef3a58ec..87244948d94f6 100644 --- a/docs/DEPRECATIONS.md +++ b/docs/DEPRECATIONS.md @@ -12,4 +12,4 @@ See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating t * armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl) ### 0.35.0 -* `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics \ No newline at end of file +* `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics From 63484d4ff5647c60bd92571674fa57753edc43b1 Mon Sep 17 00:00:00 2001 From: Doug Smith Date: Wed, 1 Nov 2023 17:11:19 -0400 Subject: [PATCH 5/5] Update DEPRECATIONS.md --- docs/DEPRECATIONS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/DEPRECATIONS.md b/docs/DEPRECATIONS.md index e369cab36de8f..2fe0d0d39fc5d 100644 --- a/docs/DEPRECATIONS.md +++ b/docs/DEPRECATIONS.md @@ -6,7 +6,7 @@ See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating t ## To be removed -### 0.34.0 +### 0.34.0 * legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed * armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl)