Fix SS58 encoding/decoding and add verification from pubkeys #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vedhavyas Do you have a bit of time to review this PR and see if we can get it in? I was going to open one myself to support sr25519 signature verification with only Public Keys and this one seems to address that. |
|
ofcourse @mikiquantum! I have some nit picks and get them in once pushed Apologies @elliot-u410. Didn't see any notification regarding this PR earlier until @mikiquantum tagged me. I hope its okay if i make some minor changes to this PR. |
|
Feel free! |
|
@elliot-u410 Thank you for the contribution 🙏🏼 |
|
@vedhavyas Noting that this change was not backwards compatible but the v1.0.4 released version number makes it seem that it was backwards compatible. |
|
updated the release now 👍🏼 |
|
Awesome @vedhavyas & thanks @elliot-u410 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to be reviewed commit-by-commit.
uint16with a very bizarre encoding. This only becomes apparent once you see a prefix > 63. This PR reimplements the SS58 handling based on the Rust implementation insp-core.Verifyusing a public key only. That is, of course, the main reason to useVerifyin the first place. This PR adds this functionality.Note very little attempt was made at maintaining backwards compatibility.
Fixes #10 and #11