From 961297dcdbd19ca37e0b69f1a8af2d49404a8baf Mon Sep 17 00:00:00 2001 From: Martijn Date: Thu, 7 Nov 2024 14:37:18 +0100 Subject: [PATCH] feat(payments-plugin): prevent false positive logging (#3195) --- packages/payments-plugin/src/mollie/mollie.service.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/payments-plugin/src/mollie/mollie.service.ts b/packages/payments-plugin/src/mollie/mollie.service.ts index 995fe7b495..0dbcbd3908 100644 --- a/packages/payments-plugin/src/mollie/mollie.service.ts +++ b/packages/payments-plugin/src/mollie/mollie.service.ts @@ -264,7 +264,12 @@ export class MollieService { `Unable to find order ${mollieOrder.orderNumber}, unable to process Mollie order ${mollieOrder.id}`, ); } + if (mollieOrder.status === OrderStatus.expired) { + // Expired is fine, a customer can retry the payment later + return; + } if (order.orderPlacedAt) { + // Verify if the Vendure order isn't already paid for, and log if so const paymentWithSameTransactionId = order.payments.find( p => p.transactionId === mollieOrder.id && p.state === 'Settled', ); @@ -293,10 +298,6 @@ export class MollieService { return; } const amount = amountToCents(mollieOrder.amount); - if (mollieOrder.status === OrderStatus.expired) { - // Expired is fine, a customer can retry the payment later - return; - } if (mollieOrder.status === OrderStatus.paid) { // Paid is only used by 1-step payments without Authorized state. This will settle immediately await this.addPayment(ctx, order, amount, mollieOrder, paymentMethod.code, 'Settled');