-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add examples for detached payload #205
Conversation
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 92.04% 92.35% +0.31%
==========================================
Files 12 12
Lines 1973 1622 -351
==========================================
- Hits 1816 1498 -318
+ Misses 108 68 -40
- Partials 49 56 +7 ☔ View full report in Codecov by Sentry. |
👀's from @veraison/go-cose-maintainers please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem like they are worth merging even if we provide a better convenience API in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for clarity of #197
Add examples of signing and verifying with detached payload for #195