Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config not applying properly; new plugins not installing #1724

Closed
2 tasks done
joeyfigaro opened this issue Apr 2, 2017 · 4 comments
Closed
2 tasks done

Config not applying properly; new plugins not installing #1724

joeyfigaro opened this issue Apr 2, 2017 · 4 comments

Comments

@joeyfigaro
Copy link

joeyfigaro commented Apr 2, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: 10.12.4 OS X
  • Hyper.app version: 1.3.1
  • Link of a Gist with the contents of your .hyper.js: .hyper.js
  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): Warning: Unknown OSC code: "1" : bundle.js:47
  • The issue is reproducible in vanilla Hyper.app: Yup! Reinstalled a couple times. Hyper isn't honoring config.

Issue

Hyper is not accepting my config updates properly. It reloads just fine, but my changes don't come through. I realize that by using hyper-snazzy, I can't set my colors. Does my config not override that of a plugin's config?

Also, adding a new plugin to plugins [] results in a refresh in hyper with an error about not being able to find the module for the plugin that was just added. Looks like npm isn't actually installing anything when I add something new, so I have to do it by hand. :)

@chabou
Copy link
Collaborator

chabou commented Apr 2, 2017

Does my config not override that of a plugin's config?

Indeed, plugins override your config. It is a good design for plugins to let user override its configuration but some plugins don't offer this.

You can use: hyperterm-final-say to define your config on top of plugins one. But use it carefully because it could break some plugins functionality (like hyper-autoprofile).

Also, adding a new plugin to plugins [] results in a refresh in hyper with an error about not being able to find the module for the plugin that was just added.

I think we need more details about your plugins installation problem. Maybe restart Hyper could help? Do you use nvm or n? is this happening each time?

@joeyfigaro
Copy link
Author

@chabou Thanks for jumping in, man. It looks like hyper is just reloading before it's done installing new dependencies. If I wait a few seconds and reload again, the error is gone and the new dependency can be found in node_modules... maybe the automatic refresh should happen after node_modules is updated.

@nesl247
Copy link
Contributor

nesl247 commented Jul 7, 2017

I too am having the issue of hyper not actually installing anything when changing the plugins array.

@Stanzilla Stanzilla mentioned this issue Jan 23, 2018
8 tasks
@albinekb
Copy link
Contributor

Fixed in v2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants